-
Notifications
You must be signed in to change notification settings - Fork 7
Apple Silicon support (it builds local too) #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This local build work on my side |
d0cdf64
to
2f14eff
Compare
I don't know much about xcode or these builds, but the link you posted me to UTM was very help to getting CI set up for gitx. FWIW, they appear to be building for
I'm sure they're more to it, but perhaps this might be helpful? |
Actually, they're doing 2 builds:
Both of those call into https://github.com/utmapp/UTM/blob/master/scripts/build_utm.sh, which looks like it ends up calling Again, I'm in over my head on this, and I don't even use an M1, but perhaps this will be helpful to you. |
@@ -1687,15 +1687,15 @@ | |||
INFOPLIST_FILE = Info.plist; | |||
LIBRARY_SEARCH_PATHS = ( | |||
"$(inherited)", | |||
/usr/local/opt/openssl/lib, | |||
/opt/homebrew/opt/openssl/lib, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These all appear to be lists of locations to search. Instead of changing /usr/local/opt/openssl/lib
to /opt/homebrew/opt/openssl/lib
, can you just add it (to all of these locations) so that both are present? That way way the linker might be able to build using /usr/local/opt/openssl/lib
but then load /opt/homebrew/opt/openssl/lib
@ runtime. Perhaps this could help us get the gitx CI builds to run on x86 and M1?
/usr/local/lib/libssh2.a, | ||
/opt/homebrew/lib/libssh2.a, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about trying something like -lssh2, -L/usr/local/lib, -L/opt/homebrew/lib
in these OTHER_LDFLAGS
declarations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing was here successful.
I asked at
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I'm glad you got something to work.
I moved to similar approach like with |
dcf6ca1
to
d5795c6
Compare
Because there is no M1 runner, currently only a local build is possible.
It's based on #15