failure building with openssl@3, works with openssl@1.1

[stepheneb]

Building gitx I got this error building the ObjectiveGit.framework in xcode 13.2.1 on macos 11.6.3.

Undefined symbols for architecture x86_64:
  "_EVP_PKEY_id", referenced from:
      __libssh2_ed25519_new_private_frommemory in libssh2.a(openssl.o)
      __libssh2_pub_priv_keyfile in libssh2.a(openssl.o)
      __libssh2_pub_priv_keyfilememory in libssh2.a(openssl.o)
ld: symbol(s) not found for architecture x86_64

Building succeeded adding LDFLAGS="-L/usr/local/opt/openssl@1.1/lib" to the ObjectiveGit.framework target build settings.

see: gitx/gitx#239 (comment)

[hannesa2]

When I do this on my x86 Mac it still fails with same error.

To be able to verify your changes locally, please can you put your changes into a pull request ?

[stepheneb]

Have master checked out separately from gitx.

$ git show
commit 972f9aad0e276d30547fdb0a3b93e26407c29a2a (HEAD -> openssl1.1, origin/master, origin/HEAD, master)
Merge: 845bab0e 8f1da7a8
Author: Hannes Achleitner <hannes.achleitner@googlemail.com>
Date:   Sun Feb 6 16:23:55 2022 +0100

    Merge pull request #29 from gitx/Xcode_13.2.1
    
    Xcode 13.2.1

Opened ObjectiveGitFramework.xcworkspace in xcode 13.2.1 on macos 11.6.3 and got this error: SWIFT_VERSION '3.0' is unsupported, supported versions are: 4.0, 4.2, 5.0.

[hannesa2]

Opened ObjectiveGitFramework.xcworkspace in xcode 13.2.1 on macos 11.6.3 and got this error: SWIFT_VERSION '3.0' is unsupported, supported versions are: 4.0, 4.2, 5.0.

I guess this should solved now with

• Bump Quick 4.0.0 #33
• Bump Nimble 9.2.1 #34
• Ci test project #35 (With updated Swift version)

@stepheneb please give it a try on recent master

[hannesa2]

On my side your primary message disappeared after a simple
brew reinstall openssl@3

[stepheneb]

Got further:

• error: no such file or directory: 'External/libssh2.a'

Steps:

• brew reinstall openssl@3.
• Checked out master branch in new dir.
• in dir: git submodule update --init --recursive
• open ObjectiveGitFramework.xcworkspace in xcode 13.2.1
• start build for my computer: macOS 11.6.3, MacBook Pro Retina, late 2013

Ld /Users/stephen/Library/Developer/Xcode/DerivedData/ObjectiveGitFramework-fyaphaesxegukpfgkwopelgpztry/Build/Products/Debug/ObjectiveGit.framework/Versions/A/ObjectiveGit normal (in target 'ObjectiveGit-Mac' from project 'ObjectiveGitFramework')
    cd /Users/stephen/dev/macos/objgit/objective-git
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -target x86_64-apple-macos10.9 -dynamiclib -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.1.sdk -L/Users/stephen/Library/Developer/Xcode/DerivedData/ObjectiveGitFramework-fyaphaesxegukpfgkwopelgpztry/Build/Products/Debug -L. -LExternal -L/usr/local/opt/openssl/lib -L/Users/stephen/dev/macos/objgit/objective-git/External/build/lib -F/Users/stephen/Library/Developer/Xcode/DerivedData/ObjectiveGitFramework-fyaphaesxegukpfgkwopelgpztry/Build/Products/Debug -filelist /Users/stephen/Library/Developer/Xcode/DerivedData/ObjectiveGitFramework-fyaphaesxegukpfgkwopelgpztry/Build/Intermediates.noindex/ObjectiveGitFramework.build/Debug/ObjectiveGit-Mac.build/Objects-normal/x86_64/ObjectiveGit.LinkFileList -install_name @rpath/ObjectiveGit.framework/ObjectiveGit -Xlinker -rpath -Xlinker @loader_path/Frameworks -Xlinker -rpath -Xlinker @executable_path/../Frameworks -Xlinker -object_path_lto -Xlinker /Users/stephen/Library/Developer/Xcode/DerivedData/ObjectiveGitFramework-fyaphaesxegukpfgkwopelgpztry/Build/Intermediates.noindex/ObjectiveGitFramework.build/Debug/ObjectiveGit-Mac.build/Objects-normal/x86_64/ObjectiveGit_lto.o -Xlinker -export_dynamic -Xlinker -no_deduplicate -fobjc-arc -fobjc-link-runtime -fapplication-extension -lgit2 -force_load External/libgit2.a External/libssh2.a -lcrypto -lssl -lcurl -lz -liconv -lgit2 -framework Cocoa -compatibility_version 1 -current_version 1 -Xlinker -dependency_info -Xlinker /Users/stephen/Library/Developer/Xcode/DerivedData/ObjectiveGitFramework-fyaphaesxegukpfgkwopelgpztry/Build/Intermediates.noindex/ObjectiveGitFramework.build/Debug/ObjectiveGit-Mac.build/Objects-normal/x86_64/ObjectiveGit_dependency_info.dat -o /Users/stephen/Library/Developer/Xcode/DerivedData/ObjectiveGitFramework-fyaphaesxegukpfgkwopelgpztry/Build/Products/Debug/ObjectiveGit.framework/Versions/A/ObjectiveGit

clang: error: no such file or directory: 'External/libssh2.a'
Command Ld failed with a nonzero exit code

[hannesa2]

you need to run ./script/bootstrap in advance.

Wrong or not, I do all in command line

[stepheneb]

What are your commands to build completely from the command line?

After clone I presume they start like this:

git submodule update --init --recursive
./script/bootstrap

Now getting this error:

Undefined symbols for architecture x86_64:
  "_EVP_PKEY_id", referenced from:
      __libssh2_ed25519_new_private_frommemory in libssh2.a(openssl.o)

More complete output from log:

Ld /Users/stephen/Library/Developer/Xcode/DerivedData/ObjectiveGitFramework-fyaphaesxegukpfgkwopelgpztry/Build/Products/Debug/ObjectiveGit.framework/Versions/A/ObjectiveGit normal (in target 'ObjectiveGit-Mac' from project 'ObjectiveGitFramework')
    cd /Users/stephen/dev/macos/objgit/objective-git
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -target x86_64-apple-macos10.9 -dynamiclib -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.1.sdk -L/Users/stephen/Library/Developer/Xcode/DerivedData/ObjectiveGitFramework-fyaphaesxegukpfgkwopelgpztry/Build/Products/Debug -L. -LExternal -L/usr/local/opt/openssl/lib -L/Users/stephen/dev/macos/objgit/objective-git/External/build/lib -F/Users/stephen/Library/Developer/Xcode/DerivedData/ObjectiveGitFramework-fyaphaesxegukpfgkwopelgpztry/Build/Products/Debug -filelist /Users/stephen/Library/Developer/Xcode/DerivedData/ObjectiveGitFramework-fyaphaesxegukpfgkwopelgpztry/Build/Intermediates.noindex/ObjectiveGitFramework.build/Debug/ObjectiveGit-Mac.build/Objects-normal/x86_64/ObjectiveGit.LinkFileList -install_name @rpath/ObjectiveGit.framework/ObjectiveGit -Xlinker -rpath -Xlinker @loader_path/Frameworks -Xlinker -rpath -Xlinker @executable_path/../Frameworks -Xlinker -object_path_lto -Xlinker /Users/stephen/Library/Developer/Xcode/DerivedData/ObjectiveGitFramework-fyaphaesxegukpfgkwopelgpztry/Build/Intermediates.noindex/ObjectiveGitFramework.build/Debug/ObjectiveGit-Mac.build/Objects-normal/x86_64/ObjectiveGit_lto.o -Xlinker -export_dynamic -Xlinker -no_deduplicate -fobjc-arc -fobjc-link-runtime -fapplication-extension -lgit2 -force_load External/libgit2.a External/libssh2.a -lcrypto -lssl -lcurl -lz -liconv -lgit2 -framework Cocoa -compatibility_version 1 -current_version 1 -Xlinker -dependency_info -Xlinker /Users/stephen/Library/Developer/Xcode/DerivedData/ObjectiveGitFramework-fyaphaesxegukpfgkwopelgpztry/Build/Intermediates.noindex/ObjectiveGitFramework.build/Debug/ObjectiveGit-Mac.build/Objects-normal/x86_64/ObjectiveGit_dependency_info.dat -o /Users/stephen/Library/Developer/Xcode/DerivedData/ObjectiveGitFramework-fyaphaesxegukpfgkwopelgpztry/Build/Products/Debug/ObjectiveGit.framework/Versions/A/ObjectiveGit

ld: warning: dylib (/usr/local/opt/openssl/lib/libcrypto.dylib) was built for newer macOS version (11.0) than being linked (10.9)
ld: warning: dylib (/usr/local/opt/openssl/lib/libssl.dylib) was built for newer macOS version (11.0) than being linked (10.9)
ld: warning: linking against a dylib which is not safe for use in application extensions: /usr/local/opt/openssl/lib/libcrypto.dylib
ld: warning: linking against a dylib which is not safe for use in application extensions: /usr/local/opt/openssl/lib/libssl.dylib
ld: warning: object file (External/libssh2.a(agent.o)) was built for newer macOS version (11.0) than being linked (10.9)
ld: warning: object file (External/libssh2.a(channel.o)) was built for newer macOS version (11.0) than being linked (10.9)
ld: warning: object file (External/libssh2.a(global.o)) was built for newer macOS version (11.0) than being linked (10.9)
ld: warning: object file (External/libssh2.a(hostkey.o)) was built for newer macOS version (11.0) than being linked (10.9)
ld: warning: object file (External/libssh2.a(session.o)) was built for newer macOS version (11.0) than being linked (10.9)
ld: warning: object file (External/libssh2.a(userauth.o)) was built for newer macOS version (11.0) than being linked (10.9)
ld: warning: object file (External/libssh2.a(misc.o)) was built for newer macOS version (11.0) than being linked (10.9)
ld: warning: object file (External/libssh2.a(openssl.o)) was built for newer macOS version (11.0) than being linked (10.9)
ld: warning: object file (External/libssh2.a(kex.o)) was built for newer macOS version (11.0) than being linked (10.9)
ld: warning: object file (External/libssh2.a(packet.o)) was built for newer macOS version (11.0) than being linked (10.9)
ld: warning: object file (External/libssh2.a(transport.o)) was built for newer macOS version (11.0) than being linked (10.9)
ld: warning: object file (External/libssh2.a(keepalive.o)) was built for newer macOS version (11.0) than being linked (10.9)
ld: warning: object file (External/libssh2.a(comp.o)) was built for newer macOS version (11.0) than being linked (10.9)
ld: warning: object file (External/libssh2.a(mac.o)) was built for newer macOS version (11.0) than being linked (10.9)
ld: warning: object file (External/libssh2.a(pem.o)) was built for newer macOS version (11.0) than being linked (10.9)
ld: warning: object file (External/libssh2.a(bcrypt_pbkdf.o)) was built for newer macOS version (11.0) than being linked (10.9)
ld: warning: object file (External/libssh2.a(crypt.o)) was built for newer macOS version (11.0) than being linked (10.9)
ld: warning: object file (External/libssh2.a(blowfish.o)) was built for newer macOS version (11.0) than being linked (10.9)
Undefined symbols for architecture x86_64:
  "_EVP_PKEY_id", referenced from:
      __libssh2_ed25519_new_private_frommemory in libssh2.a(openssl.o)
      __libssh2_pub_priv_keyfile in libssh2.a(openssl.o)
      __libssh2_pub_priv_keyfilememory in libssh2.a(openssl.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

[hannesa2]

I do almost the same like this https://github.com/gitx/objective-git/blob/master/.github/workflows/BuildPR.yml#L21-L24

But I only build arm64 (I use a M1) without x86_64

script/bootstrap && script/update_libgit2
xcodebuild -workspace ObjectiveGitFramework.xcworkspace -scheme "ObjectiveGit Mac" test archive ARCHS="arm64"

[hannesa2]

I could swear, it was working before lunch, but the test doesn't work anymore, but this works

xcodebuild -workspace ObjectiveGitFramework.xcworkspace -scheme "ObjectiveGit Mac" archive ARCHS="arm64"

This is all dirty :

And should be solved only by (architecture dependent) search path. I spent the half day with this, but still no success...

What's your output of find /opt/homebrew -name "libssh*.a" ?

[hannesa2]

Ahh, on your side the output of find /usr/local -name "libssh*.a" ?

[stepheneb]

$ find /usr/local -name "libssh*.a"
/usr/local/lib/libssh2.a
/usr/local/Cellar/libssh2/1.10.0/lib/libssh2.a

$ ls -l /usr/local/lib/libssh2.a
lrwxr-xr-x  1 stephen  admin  38 Sep 27 11:18 /usr/local/lib/libssh2.a -> ../Cellar/libssh2/1.10.0/lib/libssh2.a

In tests below I am now doing this to setup for building:

git clone git@github.com:gitx/objective-git.git
cd objective-git
git submodule update --init --recursive
script/bootstrap && script/update_libgit2

Then tried with and without test in the xcodebuild invocation:

xcodebuild -workspace ObjectiveGitFramework.xcworkspace -scheme "ObjectiveGit Mac" test archive ARCHS="x86_64"

Same error when building in xcode app:

Undefined symbols for architecture x86_64:
  "_EVP_PKEY_id", referenced from:
      __libssh2_ed25519_new_private_frommemory in libssh2.a(openssl.o)
      __libssh2_pub_priv_keyfile in libssh2.a(openssl.o)
      __libssh2_pub_priv_keyfilememory in libssh2.a(openssl.o)
ld: symbol(s) not found for architecture x86_64

xcodebuild -workspace ObjectiveGitFramework.xcworkspace -scheme "ObjectiveGit Mac" archive ARCHS="x86_64"

Different (but probably related??):

** ARCHIVE FAILED **


The following build commands failed:
	Ld /Users/stephen/Library/Developer/Xcode/DerivedData/ObjectiveGitFramework-fyaphaesxegukpfgkwopelgpztry/Build/Intermediates.noindex/ArchiveIntermediates/ObjectiveGit\ Mac/IntermediateBuildFilesPath/UninstalledProducts/macosx/ObjectiveGit.framework/Versions/A/ObjectiveGit normal (in target 'ObjectiveGit-Mac' from project 'ObjectiveGitFramework')

[hannesa2]

And do you have these files ? find . -name "libss*.a" | xargs ls -la

[stepheneb]

I only seem to have: ./External/libssh2.a

[objective-git  (master)]$ find . -name "libss*.a" | xargs ls -la
-r--r--r--  1 stephen  staff  295272 Feb 11 12:24 ./External/libssh2.a
[objective-git ruby-2.7.5 (master)]$ 

[hannesa2]

Ahh sorry, this was a pointer into the wrong direction. It was a leftover from an other try. You don't need it
This is how it looks like on my side

I tried it again in a new directory, without test (don't work for locally for arm64) and for arm64 (CI does it with x86_64)

git clone git@github.com:gitx/objective-git.git
cd objective-git
git submodule update --init --recursive
script/bootstrap && script/update_libgit2
xcodebuild -workspace ObjectiveGitFramework.xcworkspace -scheme "ObjectiveGit Mac" archive ARCHS="arm64" | tee outputARM64.log`

For me it looks like the issue is somehow related outside of the repo ? brew ?

Please can you share your output outputARM64.log to be able todo a file compare.

[stepheneb]

I've attached outputARM64.log. The build seems to have completed successfully. Building with ARCHS="x86_64" still fails as it did before.

cd ..
rm -rf objective-git
git clone git@github.com:gitx/objective-git.git && cd objective-git
git submodule update --init --recursive
script/bootstrap && script/update_libgit2
xcodebuild -workspace ObjectiveGitFramework.xcworkspace -scheme "ObjectiveGit Mac" archive ARCHS="arm64" | tee outputARM64.log

outputARM64.log

FYI: here's what's in ./External:

$ tree -L 1 External/
External/
|-- libextobjc
|-- libgit2
|-- libgit2.a
|-- libssh2
|-- libssh2.a
`-- openssl