fix: panic on small terminal when textinput for stash name is open #378
Conversation
| let new_width = r.width.max(width); | ||
| let new_height = r.height.max(height); | ||
| /// makes sure Rect `r` at least stays as big as min and not bigger than max | ||
| pub fn rect_inside(min: &Size, max: &Size, r: Rect) -> Rect { |
There was a problem hiding this comment.
these params do not need to be borrowed
There was a problem hiding this comment.
I have borrowed it because of clippy. I don't remember why. I'll check
There was a problem hiding this comment.
error: this argument is passed by value, but not consumed in the function body
--> src/ui/mod.rs:75:25
|
75 | pub fn rect_inside(min: Size, max: Size, r: Rect) -> Rect {
| ^^^^ help: consider taking a reference instead: &Size
|
note: the lint level is defined here
--> src/main.rs:4:9
|
4 | #![deny(clippy::pedantic)]
| ^^^^^^^^^^^^^^^^
= note: #[deny(clippy::needless_pass_by_value)] implied by #[deny(clippy::pedantic)]
help: consider marking this type as Copy
|
@alocquet thanks man! hope you don't stop now that you have hacktoberfest fulfilled :P |
|
I will have less time because I'm starting a new job next week. But I'll try to continue working on gitui. |
2 participants
fix #370