Skip to content

feat: password obfuscation #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2020
Merged

feat: password obfuscation #376

merged 1 commit into from
Oct 27, 2020

Conversation

alocquet
Copy link
Contributor

fix #361
I don't know if it is ok for you but I managed this one with an input type :

  • TEXTAREA = previous behavior
  • TEXT : input on one line
  • PASSWORD : input on one line and obfuscated

@extrawurst
Copy link
Collaborator

@alocquet sounds cool but lets call it more specifically

pub enum InputType {
     SINGLELINE,
     MULTILINE,
     PASSWORD,
 }

extrawurst
extrawurst requested changes Oct 26, 2020
View reviewed changes
@alocquet alocquet force-pushed the feature/password_obfuscation branch 2 times, most recently from 4c69dad to 14a1466 Compare October 27, 2020 10:39
@extrawurst extrawurst merged commit a75f43d into gitui-org:master Oct 27, 2020
@extrawurst
Copy link
Collaborator

Nice! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@extrawurst extrawurst extrawurst requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

password obfuscation
2 participants
@alocquet @extrawurst