-
Notifications
You must be signed in to change notification settings - Fork 52
Updated nginx.mdx to remind about reloading nginx after adding conf file #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@pluseg is attempting to deploy a commit to the Listinai Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe documentation for configuring Nginx as a reverse proxy was updated to explicitly instruct users to reload Nginx after enabling the site configuration and before obtaining an SSL certificate with Certbot. This clarifies the necessary sequence of commands for proper setup. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pages/reverse-proxies/nginx.mdx (1)
55-57
: Align reload command with the rest of the doc and add sudoLater in the guide (
### Reload Nginx
) you usesudo systemctl reload nginx
.
Here, the barenginx -s reload
(a) omitssudo
, so it will fail for non-root users, and (b) mixesnginx -s
withsystemctl
, which may confuse newcomers. Consider making the wording/command consistent:-Restart nginx to apply the changes: `nginx -s reload`. (Important to do before obtaining SSL certificate below.) +Reload Nginx to apply the changes: `sudo systemctl reload nginx` (or `sudo nginx -t && sudo nginx -s reload`) before obtaining the SSL certificate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Nginx documentation to include an explicit step for reloading Nginx after enabling a site configuration. This ensures that configuration changes are properly applied before attempting to obtain SSL certificates.
- Adds a reminder to reload Nginx after creating the symbolic link to enable the site
- Emphasizes the importance of this step before SSL certificate generation
Co-authored-by: Copilot <[email protected]>
Summary by CodeRabbit