Skip to content

[kots] Fix typo in the s3 storage secret name #9942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2022
Merged

[kots] Fix typo in the s3 storage secret name #9942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion install/kots/manifests/gitpod-storage-s3-secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
apiVersion: v1
kind: Secret
metadata:
name: storage-azure
name: storage-s3
labels:
app: gitpod
component: gitpod-installer
Expand Down
8 changes: 4 additions & 4 deletions install/kots/manifests/kots-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,18 +242,18 @@ spec:
help_text: The endpoint used to connect to the S3 storage.

- name: store_s3_access_key_id
title: Username
title: Access Key
type: text
required: true
when: '{{repl (ConfigOptionEquals "store_provider" "s3") }}'
help_text: The username that has access to the S3 account. In AWS, this is an IAM user's credentials with `AmazonS3FullAccess` policy.
help_text: Access key of IAM user's credentials with `AmazonS3FullAccess` policy.

- name: store_s3_secret_access_key
title: Password
title: Secret Key
type: password
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pothulapati Is this a file that you add here? If yes, should we change this to file upload here (follow-up issue)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File? 🤔 Secret Key is just a title name for the field as the user expressed confusion over the naming here!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, It's not a file! Just a secret key. Should this be a file instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, 💡! I thought it would be a service account key file or something similar. Nevermind!

required: true
when: '{{repl (ConfigOptionEquals "store_provider" "s3") }}'
help_text: The password that has access to the S3 account. In AWS, this is an IAM user's credentials with `AmazonS3FullAccess` policy.
help_text: Secret key of IAM user's credentials with `AmazonS3FullAccess` policy.

- name: certs
title: TLS certificates
Expand Down