-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[kots] Fix typo in the s3 storage secret name #9942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix #9911 `storage-s3` is miswritten as `storage-azure`, causing s3 to not work in the `kots` setup. This fixes that issue, while also renaming the help fields to be less confusing and more specific to aws. Signed-off-by: Tarun Pothulapati <[email protected]>
/hold as I also investigate #9800 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
Edit: Didn't see the hold sign, well this approval can be used for later
It looks like #9800 is an issue with |
Makes sense @nandajavarma /unhold |
|
||
- name: store_s3_secret_access_key | ||
title: Password | ||
title: Secret Key | ||
type: password |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pothulapati Is this a file that you add here? If yes, should we change this to file upload here (follow-up issue)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File? 🤔 Secret Key is just a title name for the field as the user expressed confusion over the naming here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, It's not a file! Just a secret key. Should this be a file instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, 💡! I thought it would be a service account key file or something similar. Nevermind!
Description
storage-s3
is miswritten asstorage-azure
, causing s3to not work in the
kots
setup. This fixes that issue, whilealso renaming the help fields to be less confusing and more
specific to aws.
Signed-off-by: Tarun Pothulapati [email protected]
Related Issue(s)
Fix #9911
How to test
Release Notes
Documentation