Skip to content

[kots] Fix typo in the s3 storage secret name #9942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2022
Merged

Conversation

Pothulapati
Copy link
Contributor

Description

storage-s3 is miswritten as storage-azure, causing s3
to not work in the kots setup. This fixes that issue, while
also renaming the help fields to be less confusing and more
specific to aws.

Signed-off-by: Tarun Pothulapati [email protected]

Related Issue(s)

Fix #9911

How to test

Release Notes

[kots] Fix issue with s3 object storage

Documentation

Fix #9911

`storage-s3` is miswritten as `storage-azure`, causing s3
to not work in the `kots` setup. This fixes that issue, while
also renaming the help fields to be less confusing and more
specific to aws.

Signed-off-by: Tarun Pothulapati <[email protected]>
@Pothulapati Pothulapati requested a review from a team May 11, 2022 15:32
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label May 11, 2022
@Pothulapati
Copy link
Contributor Author

/hold as I also investigate #9800

Copy link
Contributor

@nandajavarma nandajavarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!
Edit: Didn't see the hold sign, well this approval can be used for later

@nandajavarma
Copy link
Contributor

It looks like #9800 is an issue with registry-s3-backend and not storage-backend, in which case may be we can let this PR merged before the release and investigate that separately?

@Pothulapati
Copy link
Contributor Author

Makes sense @nandajavarma

/unhold

@roboquat roboquat merged commit dfb44e4 into main May 24, 2022
@roboquat roboquat deleted the tar/kots-s3-fix branch May 24, 2022 15:14

- name: store_s3_secret_access_key
title: Password
title: Secret Key
type: password
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pothulapati Is this a file that you add here? If yes, should we change this to file upload here (follow-up issue)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File? 🤔 Secret Key is just a title name for the field as the user expressed confusion over the naming here!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, It's not a file! Just a secret key. Should this be a file instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, 💡! I thought it would be a service account key file or something similar. Nevermind!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/S team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KOTS: S3 external object storage is not working
4 participants