Updated Readme.md #9647
Closed
Updated Readme.md #9647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the wording to point to the default installation method we want people to use.
github-actions
bot
added
the
team: delivery
corneliusludmann
approved these changes
Apr 29, 2022
|
/werft run |
|
/werft run 👍 started the job as gitpod-build-lucasvaltl-installer-readme-update.1 |
|
@lucasvaltl Sorry, had to move back to draft bc it was blocking the merge queue. 😕 |
|
Wanted to do this as well right now. Thanks Gero! 🙏 @lucasvaltl I guess you need to rebase this PR anyways to fix the build error as soon as #9648 is in. |
|
@lucasvaltl I confirm that rebasing the branch will solve the problem of Werft failing to build. |
Where we need it, take it from the environment.
This was previously hard-coded to false in the server configmap.
This was previously hard-coded to true in the server configmap.
This was previously hard-coded to empty in the server configmap.
Extract named structs for fields that were nested under `ServerConfig` so that they can be instantiated in tests.
|
Eeeeh I tried rebasing, let's just say I'm just going to start with a fresh PR :D Feels like that is easier. Closing this and restarting this :) |
|
---> trying again here #9658 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the wording to point to the default installation method we want people to use.
Related to https://github.com/gitpod-io/website/pull/1975
Release Notes