[server] reduce project inactivity time to 1 week (was 10) #9608
Conversation
|
@jankeromnes Could you PTAL? 🙏 |
svenefftinge
changed the title
There was a problem hiding this comment.
Many thanks for this Pull Request! FYI, 10 weeks was intentionally very lax, in order to test this new behavior on a smaller scale, before making it more aggressive.
The 10-weeks-cancel change was effectively enabled in production this Monday (3 days ago), and we should see the first results/savings in our internal Prebuilds dashboard starting next week.
We can already see in the DB that 4384 prebuilds got auto-cancelled since 2022-04-25T08:34, or about 1 prebuild every minute that we decide not to run.
I agree with making this more aggressive, and now seems to be a good time.
Note: 1 week seems quite aggressive, and will likely cause some "false positives", for example most Projects might become "inactive" over the summer or winter holidays, or smaller Projects if the team goes on holidays, or becomes somewhat inactive, etc. However, the impact is minimal, and a brief visit to the Prebuild details (or a simple workspace start) are enough to resolve this. So, 2 weeks would seem safer, but 1 week should be fine.
| @@ -353,7 +353,7 @@ export class PrebuildManager { | |||
| } | |||
| const now = Date.now(); | |||
| const lastUse = new Date(usage.lastWorkspaceStart).getTime(); | |||
| const inactiveProjectTime = 1000 * 60 * 60 * 24 * 7 * 10; // 10 weeks | |||
| const inactiveProjectTime = 1000 * 60 * 60 * 24 * 7 * 1; // 1 week | |||
There was a problem hiding this comment.
Nit: * 1 is unnecessary.
| const inactiveProjectTime = 1000 * 60 * 60 * 24 * 7 * 1; // 1 week | |
| const inactiveProjectTime = 1000 * 60 * 60 * 24 * 7; // 1 week |
This PR marks projects as inactive when there has been no workspace for more than a week. As a result, Gitpod will stop preparing workspaces through prebuilds.
I believe we can and should be more aggressive here, to not waste money (and energy). If there are pushes but no workspaces for a repo we can consider it inactive.