-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add maximumBackupCount
and blobQuota
configuration surface to the installer
#9227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Previously, this was hardcoded to 3 but needs to be configurable for Gitpod SaaS.
Previously, this was hardcoded to 5GiB but needs to be configurable for Gitpod SaaS.
Pulling workspace (in person of @kylos101 ) in here because they own the |
@mrsimonemms Would you have time to review this? 🙏 |
@geropl anything for my friends in WebApp 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work.
Is this a value we expect that a self-hosted user would be wanting to change - maybe not a small deployment, but a big bank/govt agency? If so, @gitpod-io/engineering-self-hosted may need to think about how we put this in KOTS (the "advanced" section may be enough)
@mrsimonemms Exactly where I'd put it: not interesting for Gitpod 101 Self-Hosted installation, but interesting for installs that are a bit more regulated. |
Great - advanced section it is. That suits me as a) we don't need to do anything and b) it doesn't clutter up the config page with extra things that someone could break |
Description
One of the Webapp team's epics for Q2 is to use the Gitpod installer to deploy to Gitpod SaaS. In order to do that we may need to add additional configuration to the installer to make the output suitable for a SaaS deployment as opposed to a self-hosted deployment.
This PR adds configuration for two such values,
maximumBackupCount
andblobQuota
, which are currently hard-coded in the installer but need to be configurable for SaaS.Related Issue(s)
Part of #9097.
How to test
Build the installer and run it with
Where the config file contains a
objectStorage
configuration section including the new values, like:The rendered output for the
content-service
configMap should then contain the new values under theconfig.json
key:Release Notes
Documentation
No changes required as these values should be left at the pre-existing defaults to self-hosted installations.