Skip to content

Conversation

csweichel
Copy link
Contributor

Description

This PR adds Redis-based caching for manifests and blogs to registry-facade. This dramatically speeds up manifest assembly.

Related Issue(s)

Fixes #9006

Don't know what happened with #9028. This is a replacement.

Note: most commits are shared with #9005. Only last commit is actually new.

How to test

# install oci-tool
go install github.com/csweichel/coi-tool@latest

# start redis
docker run --name redis -p 6379:6379 -d redis

# start registry-facade
cd components/registry-facade
go run main.go run example-config.json

# pull a manifest
time oci-tool fetch --insecure manifest localhost:9090/fixed/foo:latest

# pull a manifest again - observe the difference in time
time oci-tool fetch --insecure manifest localhost:9090/fixed/foo:latest

# pull a different manifest - observe that it took less than the original 2 seconds
time oci-tool fetch --insecure manifest localhost:9090/fixed/bar:latest

# pull a different manifest again - observe the difference in time
time oci-tool fetch --insecure manifest localhost:9090/fixed/bar:latest

Release Notes

Improve workspace startup time through improved manifest assembly

@csweichel csweichel requested a review from a team April 1, 2022 10:53
@github-actions github-actions bot added team: workspace Issue belongs to the Workspace team and removed size/XXL labels Apr 1, 2022
@csweichel
Copy link
Contributor Author

csweichel commented Apr 1, 2022

/werft run with-clean-slate

👍 started the job as gitpod-build-cw-regfac-redis.5

@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Apr 1, 2022
@csweichel csweichel requested a review from aledbf as a code owner April 1, 2022 13:44
@csweichel csweichel requested a review from a team April 1, 2022 13:44
Copy link
Member

@aledbf aledbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit 296d3bf into cw/regfac-ipfs Apr 1, 2022
@roboquat roboquat deleted the cw/regfac-redis branch April 1, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/XXL team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants