Skip to content

Revert "ui: enlarge search box on dashboard" #8969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2022
Merged

Revert "ui: enlarge search box on dashboard" #8969

merged 1 commit into from
Mar 28, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Mar 28, 2022 •
edited
Loading

This reverts commit 8b9a40a.

I have accidentally merged the PR by approving it (and missing there's no hold on the PR).

Release Notes

NONE

Documentation

@easyCZ easyCZ requested a review from a team March 28, 2022 13:05
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Mar 28, 2022
@easyCZ
Copy link
Member Author

easyCZ commented Mar 28, 2022

CC @gtsiolis

Relates to #8813

@easyCZ easyCZ mentioned this pull request Mar 28, 2022
Merged
gtsiolis
gtsiolis approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@gtsiolis gtsiolis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround, @easyCZ! 🏓

fyi: @tnir We had to revert #8813 which was accidentally merged as it caused a UX regression. Feel free to re-open a PR with a fix after this is merged including some BEFORE / AFTER screenshots with the visual changes.

BEFORE AFTER
Screenshot 2022-03-28 at 4 12 52 PM Screenshot 2022-03-28 at 4 12 20 PM

jldec
jldec approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@jldec jldec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@roboquat roboquat merged commit 37916d4 into main Mar 28, 2022
@roboquat roboquat deleted the mp/revert-search-box branch March 28, 2022 14:17
@jankeromnes jankeromnes mentioned this pull request Mar 29, 2022
Closed
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Mar 31, 2022
@tnir
Copy link
Contributor

tnir commented Mar 31, 2022

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@gtsiolis gtsiolis gtsiolis approved these changes

@jldec jldec jldec approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@easyCZ @tnir @gtsiolis @jldec @roboquat