Remove Theia extension related code #8685

mustard-mh · 2022-03-09T12:13:41Z

Description

Remove Theia extension related code

Related Issue(s)

How to test

Start A workspace to do the smoke test like release do #8609
I have did this all (although I think we don't need to do this many steps 😄)

Start a workspace.
Test following:
- terminals are preserved and resized properly between window reloads
- WebViews are working
- extension host process: check language smartness and debugging
- extension management (installing/uninstalling)
- install the VIM extension to test web extensions
- that user data are sync across workspaces as well as on workspace restart, especially for extensions
- extensions from .gitpod.yml are not installed as sync
- extensions installed as sync are actually sync in new workspaces
- settings should not contain any mentions of MS telemetry
- websockets and workers are properly proxied
  - diff editor should be operatable
  - trigger reconnection with window.WebSocket.disconnectWorkspace(), check that old websockets are closed and new opened of the same amount
- workspace specific commands should work, i.e. F1 → type Gitpod prefix
- that a PR view is preloaded on the PR url
- test gp open and preview
- test open in VS Code Desktop, check gp open and preview in task/user terminals
- ~~telemetry data is collected in Segment~~

Release Notes

NONE

Documentation

mustard-mh · 2022-03-09T12:16:46Z

components/gitpod-protocol/BUILD.yaml

@@ -17,13 +17,6 @@ packages:
      packaging: library
      yarnLock: ${coreYarnLockBase}/yarn.lock
      tsconfig: tsconfig.json
-  - name: theia-plugin-list


global searched theia-plugin-list -> no usage

components/server/src/theia-plugin/theia-plugin-service.ts

mustard-mh · 2022-03-09T12:22:11Z

/hold
I have split these into several commits for review

need squash commits

codecov · 2022-03-09T15:05:41Z

Codecov Report

Merging #8685 (841eb6d) into main (af79008) will decrease coverage by 1.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8685      +/-   ##
==========================================
- Coverage   12.31%   11.17%   -1.14%     
==========================================
  Files          20       18       -2     
  Lines        1161      993     -168     
==========================================
- Hits          143      111      -32     
+ Misses       1014      880     -134     
+ Partials        4        2       -2

Flag	Coverage Δ
components-gitpod-cli-app	`11.17% <ø> (ø)`
components-local-app-app-darwin-amd64	`?`
components-local-app-app-darwin-arm64	`?`
components-local-app-app-linux-amd64	`?`
components-local-app-app-linux-arm64	`?`
components-local-app-app-windows-386	`?`
components-local-app-app-windows-amd64	`?`
components-local-app-app-windows-arm64	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

akosyakov · 2022-03-10T09:25:04Z

@mustard-mh Could you provide How to test section? We should smoke test that workspaces still start and extensions are there. Do you do any other testing?

mustard-mh · 2022-03-10T11:33:18Z

How to test section updated ✅

felladrin

Code reviewed and also tested with a production app that uses most of the features mentioned in the How To Test section. Everything's working great! ✅

I also verified each checklist item in the How To Test section.

andreafalzetti · 2022-03-11T10:30:47Z

Shall we also remove this file? components/gitpod-cli/generate-theia-protocol.go

geropl

LGTM

mustard-mh · 2022-03-11T18:34:48Z

/unhold

mustard-mh · 2022-03-11T18:38:22Z

/werft run no-preview

👍 started the job as gitpod-build-hw-fix-4630.7

mustard-mh · 2022-03-11T18:39:58Z

/hold

mustard-mh · 2022-03-11T18:46:24Z

Shall we also remove this file? components/gitpod-cli/generate-theia-protocol.go

@andreafalzetti maybe other PR to remove theia things

mustard-mh · 2022-03-11T18:46:32Z

/unhold

roboquat added do-not-merge/work-in-progress release-note-none size/XXL labels Mar 9, 2022

mustard-mh force-pushed the hw/fix-4630 branch from b809f0b to 6912cf3 Compare March 9, 2022 12:15

mustard-mh commented Mar 9, 2022

View reviewed changes

components/server/src/theia-plugin/theia-plugin-service.ts Outdated Show resolved Hide resolved

roboquat added the do-not-merge/hold label Mar 9, 2022

mustard-mh marked this pull request as ready for review March 9, 2022 12:22

mustard-mh requested a review from a team March 9, 2022 12:22

roboquat removed the do-not-merge/work-in-progress label Mar 9, 2022

github-actions bot added the team: webapp Issue belongs to the WebApp team label Mar 9, 2022

mustard-mh requested a review from a team March 9, 2022 12:23

github-actions bot added the team: IDE label Mar 9, 2022

mustard-mh marked this pull request as draft March 10, 2022 10:14

roboquat added the do-not-merge/work-in-progress label Mar 10, 2022

mustard-mh marked this pull request as ready for review March 10, 2022 11:32

roboquat removed the do-not-merge/work-in-progress label Mar 10, 2022

felladrin previously approved these changes Mar 10, 2022

View reviewed changes

mustard-mh dismissed felladrin’s stale review via 471beee March 10, 2022 14:06

mustard-mh force-pushed the hw/fix-4630 branch from 808d27b to 471beee Compare March 10, 2022 14:06

Remove Theia extension related code

841eb6d

mustard-mh force-pushed the hw/fix-4630 branch from 471beee to 841eb6d Compare March 10, 2022 14:06

felladrin approved these changes Mar 10, 2022

View reviewed changes

geropl approved these changes Mar 11, 2022

View reviewed changes

roboquat removed the do-not-merge/hold label Mar 11, 2022

roboquat added the do-not-merge/hold label Mar 11, 2022

roboquat removed the do-not-merge/hold label Mar 11, 2022

roboquat merged commit f608089 into main Mar 11, 2022

roboquat deleted the hw/fix-4630 branch March 11, 2022 18:47

roboquat added the deployed: webapp Meta team change is running in production label Mar 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove Theia extension related code #8685

Remove Theia extension related code #8685

Uh oh!

mustard-mh commented Mar 9, 2022 •

edited

Loading

Uh oh!

mustard-mh Mar 9, 2022

Uh oh!

Uh oh!

mustard-mh commented Mar 9, 2022 •

edited

Loading

Uh oh!

codecov bot commented Mar 9, 2022 •

edited

Loading

Uh oh!

akosyakov commented Mar 10, 2022

Uh oh!

mustard-mh commented Mar 10, 2022 •

edited by werft-gitpod-dev-com bot

Loading

Uh oh!

felladrin left a comment

Uh oh!

andreafalzetti commented Mar 11, 2022 •

edited

Loading

Uh oh!

geropl left a comment

Uh oh!

mustard-mh commented Mar 11, 2022

Uh oh!

mustard-mh commented Mar 11, 2022 •

edited by werft-gitpod-dev-com bot

Loading

Uh oh!

mustard-mh commented Mar 11, 2022

Uh oh!

mustard-mh commented Mar 11, 2022

Uh oh!

mustard-mh commented Mar 11, 2022

Uh oh!

Uh oh!

Remove Theia extension related code #8685

Remove Theia extension related code #8685

Uh oh!

Conversation

mustard-mh commented Mar 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue(s)

How to test

Release Notes

Documentation

Uh oh!

mustard-mh Mar 9, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mustard-mh commented Mar 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

akosyakov commented Mar 10, 2022

Uh oh!

mustard-mh commented Mar 10, 2022 • edited by werft-gitpod-dev-com bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

felladrin left a comment

Choose a reason for hiding this comment

Uh oh!

andreafalzetti commented Mar 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

geropl left a comment

Choose a reason for hiding this comment

Uh oh!

mustard-mh commented Mar 11, 2022

Uh oh!

mustard-mh commented Mar 11, 2022 • edited by werft-gitpod-dev-com bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mustard-mh commented Mar 11, 2022

Uh oh!

mustard-mh commented Mar 11, 2022

Uh oh!

mustard-mh commented Mar 11, 2022

Uh oh!

Uh oh!

mustard-mh commented Mar 9, 2022 •

edited

Loading

mustard-mh commented Mar 9, 2022 •

edited

Loading

codecov bot commented Mar 9, 2022 •

edited

Loading

mustard-mh commented Mar 10, 2022 •

edited by werft-gitpod-dev-com bot

Loading

andreafalzetti commented Mar 11, 2022 •

edited

Loading

mustard-mh commented Mar 11, 2022 •

edited by werft-gitpod-dev-com bot

Loading