Skip to content

Conversation

corneliusludmann
Copy link
Contributor

Description

This change is a tidy-up of what is generated with installer init. It ...

  • adds a default value to disableDefinitelyGp
  • adds omitempty for values that are null by default (be more consistent, alternative: remove omitemtpy more or less everywhere and render all null values)
  • updates the example-config.yaml file

How to test

Nothing to do, just look at the updated example-config.yaml file and express your feelings about this change.

Release Notes

NONE

Meta

/werft no-preview

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #8436 (b1d2388) into main (63d893c) will decrease coverage by 0.82%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##            main   #8436      +/-   ##
========================================
- Coverage   8.41%   7.59%   -0.83%     
========================================
  Files         33      31       -2     
  Lines       2340    2172     -168     
========================================
- Hits         197     165      -32     
+ Misses      2138    2004     -134     
+ Partials       5       3       -2     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
install-installer-raw-app 4.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63d893c...b1d2388. Read the comment docs.

@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Feb 24, 2022
Copy link
Contributor

@mrsimonemms mrsimonemms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omitempty is my friend - terser config is good config

@roboquat roboquat merged commit 6afc7f2 into main Feb 24, 2022
@roboquat roboquat deleted the clu/installer-omitempty branch February 24, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/S team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants