Skip to content

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Feb 18, 2022

Description

Add a note of clarification on how to use AWS ECR as push registry. Thanks to @eiymba for asking the question

As was in this section, I've added some validation on the secret

Related Issue(s)

Fixes #8321

How to test

Release Notes

NONE

Documentation

@mrsimonemms mrsimonemms requested a review from a team February 18, 2022 20:18
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Feb 18, 2022
@mrsimonemms mrsimonemms added component: install Terraform installation scripts, helm charts, installer images and removed size/S labels Feb 18, 2022
@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #8322 (02c25f2) into main (f41c652) will decrease coverage by 25.40%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #8322       +/-   ##
==========================================
- Coverage   33.00%   7.60%   -25.41%     
==========================================
  Files          33      31        -2     
  Lines        4735    2171     -2564     
==========================================
- Hits         1563     165     -1398     
+ Misses       3054    2003     -1051     
+ Partials      118       3      -115     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-installer-raw-app 4.58% <ø> (?)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-arm64 ?
components-ws-manager-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/ws-manager/pkg/manager/internal/grpcpool/pool.go
...omponents/ws-manager/pkg/manager/pod_controller.go
components/ws-manager/pkg/manager/create.go
components/ws-manager/pkg/manager/monitor.go
components/local-app/pkg/auth/pkce.go
components/ws-manager/pkg/manager/manager_ee.go
components/ws-manager/pkg/manager/metrics.go
...-manager/pkg/manager/internal/workpool/workpool.go
components/ws-manager/pkg/clock/clock.go
components/ws-manager/pkg/manager/status.go
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f41c652...02c25f2. Read the comment docs.

@roboquat roboquat added size/M and removed size/S labels Feb 18, 2022
@mrsimonemms mrsimonemms marked this pull request as ready for review February 18, 2022 20:50
@roboquat roboquat merged commit e2d8e2d into main Feb 21, 2022
@roboquat roboquat deleted the sje/installer-s3-ecr branch February 21, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: install Terraform installation scripts, helm charts, installer images release-note-none size/M team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container Registry and S3 Clarification In The Docs
3 participants