Skip to content

increase downloadOTS attempts to 20 #8164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

sagor999
Copy link
Contributor

Description

As described in #8096 we sometimes fail to download OTS due to db not being in sync.
As suggested by @geropl a bandaid solution for now is to increase timeout to 20 sec from 10sec that should cover 99% of cases. Each attempt is done every second.

Related Issue(s)

Fixes #8096

How to test

Release Notes

none

Documentation

@sagor999 sagor999 requested a review from a team February 11, 2022 22:00
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Feb 11, 2022
@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #8164 (8fdf21e) into main (1870c12) will decrease coverage by 3.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8164      +/-   ##
==========================================
- Coverage   33.56%   30.03%   -3.53%     
==========================================
  Files          33      107      +74     
  Lines        4657    17513   +12856     
==========================================
+ Hits         1563     5260    +3697     
- Misses       2976    11810    +8834     
- Partials      118      443     +325     
Flag Coverage Δ
components-content-service-app 13.92% <ø> (?)
components-content-service-lib 13.92% <ø> (?)
components-gitpod-cli-app 11.17% <ø> (ø)
components-image-builder-mk3-app 35.71% <ø> (?)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-supervisor-app 35.31% <ø> (?)
components-ws-daemon-app 22.45% <ø> (?)
components-ws-daemon-lib 22.45% <ø> (?)
components-ws-manager-app 40.61% <ø> (ø)
components-ws-proxy-app 68.32% <ø> (?)
installer-raw-app 5.63% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nts/content-service/pkg/initializer/initializer.go 4.66% <ø> (ø)
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go
components/content-service/pkg/layer/provider.go 36.76% <0.00%> (ø)
components/supervisor/pkg/ports/served-ports.go 80.76% <0.00%> (ø)
components/supervisor/pkg/supervisor/user.go 32.29% <0.00%> (ø)
components/content-service/pkg/git/porcelain.go 91.89% <0.00%> (ø)
components/content-service/pkg/git/git.go 36.93% <0.00%> (ø)
...onents/content-service/pkg/service/blob-service.go 0.00% <0.00%> (ø)
components/content-service/pkg/archive/tar.go 60.31% <0.00%> (ø)
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1870c12...8fdf21e. Read the comment docs.

@roboquat roboquat merged commit 709fc0c into main Feb 14, 2022
@roboquat roboquat deleted the sagor999/failed-to-download-ots-8096 branch February 14, 2022 06:07
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to download OTS in US cluster (possibly happens for prebuilds, only)
3 participants