Skip to content

Truncate workspace name on workspace start page #8126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Feb 9, 2022

Description

Following the fix in #7711 (comment) that wil truncate the new workspace name in the workspace start page, this will duplicate this approach to truncate the workspace name on all workspace start pages.

How to test

  1. Start a new workspace
  2. Stop the workspace or let the workspace time out
  3. Notice the workspace name no longer wraps but is truncated

Screenshots

BEFORE AFTER
Screenshot 2022-02-09 at 8 24 17 PM (2) Screenshot 2022-02-09 at 8 24 25 PM (2)

Release Notes

NONE

Documentation

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #8126 (fdc11b7) into main (89950b7) will decrease coverage by 10.58%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #8126       +/-   ##
==========================================
- Coverage   18.61%   8.03%   -10.59%     
==========================================
  Files          58      31       -27     
  Lines        6408    2215     -4193     
==========================================
- Hits         1193     178     -1015     
+ Misses       5117    2034     -3083     
+ Partials       98       3       -95     
Flag Coverage Δ
components-ee-agent-smith-app ?
components-ee-agent-smith-lib ?
components-gitpod-cli-app 10.82% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-workspacekit-app ?
components-ws-daemon-app ?
components-ws-daemon-lib ?
installer-raw-app 5.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ee/agent-smith/pkg/agent/metrics.go
components/ws-daemon/pkg/cpulimit/cpulimit.go
...onents/ws-daemon/pkg/internal/session/workspace.go
components/ws-daemon/pkg/content/initializer.go
components/ws-daemon/pkg/quota/size.go
components/ws-daemon/pkg/internal/session/store.go
components/ws-daemon/pkg/content/hooks.go
components/workspacekit/cmd/lift.go
components/workspacekit/cmd/root.go
components/ee/agent-smith/pkg/agent/egress.go
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89950b7...fdc11b7. Read the comment docs.

Copy link
Contributor

@JanKoehnlein JanKoehnlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit 1f562b6 into main Feb 10, 2022
@roboquat roboquat deleted the gt/truncate-workspace-name branch February 10, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants