Skip to content

Improve colors used for labels and headings on dashboard integrations… #7068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2021

Conversation

pri1311
Copy link
Contributor

@pri1311 pri1311 commented Dec 5, 2021

… for the dark theme

Description

Improve colors used for labels and headings on dashboard integrations for the dark theme. Changes mentioned in the PR were made.

Related Issue(s)

Fixes #6762

How to test

Release Notes

NONE

Documentation

@gtsiolis
Copy link
Contributor

gtsiolis commented Dec 6, 2021

/werft run

👍 started the job as gitpod-build-main-fork.17

@gtsiolis gtsiolis self-requested a review December 6, 2021 20:48
@gtsiolis gtsiolis added the do-not-merge/cla-pending CLA has not been signed label Dec 6, 2021
@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #7068 (f92c3e0) into main (302dc2b) will not change coverage.
The diff coverage is n/a.

❗ Current head f92c3e0 differs from pull request most recent head cd7ba60. Consider uploading reports for the commit cd7ba60 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7068   +/-   ##
=======================================
  Coverage   19.04%   19.04%           
=======================================
  Files           2        2           
  Lines         168      168           
=======================================
  Hits           32       32           
  Misses        134      134           
  Partials        2        2           
Flag Coverage Δ
components-local-app-app-linux-amd64 19.04% <ø> (ø)
components-local-app-app-linux-arm64 ∅ <ø> (∅)
components-local-app-app-windows-386 ∅ <ø> (∅)
components-local-app-app-windows-amd64 ∅ <ø> (∅)
components-local-app-app-windows-arm64 ∅ <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 302dc2b...cd7ba60. Read the comment docs.

Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, @pri1311! 🌟

Changes look great! 🏁

I've also triggered a preview environment (deployment) where you can see a deployed version with the changes in this PR, see #7068 (comment). 🌔

You'll also need to sign a Contributor License Agreement (CLA)[1] once before merging your first contribution. Looping in @meysholdt to reach out about the CLA. 🏓

Approving but holding until the CLA process is complete.

/hold

@roboquat
Copy link
Contributor

roboquat commented Dec 6, 2021

LGTM label has been added.

Git tree hash: f26cb2bade94a899c1f7c0bdf19780f6f6099a42

@meysholdt
Copy link
Member

Hi Priya,

I've sent you a CLA via DocuSign, can you please sign it so that we can merge this PR?
thank you!

@pri1311
Copy link
Contributor Author

pri1311 commented Dec 14, 2021

Hey @meysholdt
Have signed the document.

@stale
Copy link

stale bot commented Dec 24, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Dec 24, 2021
@gtsiolis gtsiolis removed the meta: stale This issue/PR is stale and will be closed soon label Dec 27, 2021
@meysholdt meysholdt added cla: accepted ✔️ and removed do-not-merge/cla-pending CLA has not been signed labels Dec 27, 2021
@gtsiolis
Copy link
Contributor

gtsiolis commented Dec 27, 2021

/werft run

👍 started the job as gitpod-build-main-fork.18

@gtsiolis
Copy link
Contributor

Rebased and shortened the commit message. Removing hold.

/hold cancel

@gtsiolis
Copy link
Contributor

gtsiolis commented Dec 27, 2021

/werft run

👍 started the job as gitpod-build-main-fork.19
/lgtm

@roboquat roboquat added the lgtm label Dec 27, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: f26cb2bade94a899c1f7c0bdf19780f6f6099a42

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gtsiolis

Associated issue: #6762

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit b53c34d into gitpod-io:main Dec 27, 2021
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cla: accepted ✔️ community-contribution deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve colors used for labels and headings on dashboard integrations for the dark theme
4 participants