-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[ws-proxy] Get supervisor image from pod annotation instead from ws-proxy config #6697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6697 +/- ##
==========================================
+ Coverage 36.69% 38.04% +1.34%
==========================================
Files 21 20 -1
Lines 4745 2195 -2550
==========================================
- Hits 1741 835 -906
+ Misses 2868 1309 -1559
+ Partials 136 51 -85
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
instead from ws-proxy config
660ff1f
to
96be1b2
Compare
Works as advertised and code LGTM. /hold |
LGTM label has been added. Git tree hash: 4fe75a85cceebbc7b2e285f18ec52db307c91790
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csweichel Associated issue: #6512 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Description
This PR removes the
ws-proxy
config value that specifies the supervisor image. Instead of using this config value, thesupervisor
image from theImageSpec
annotation is used. This …ws-proxy
config + pod restart, andsupervisor
images.Related Issue(s)
Fixes #6512
How to test
ws-proxy
logs likeno workspace information available - cannot resolve supervisor route
Release Notes