Skip to content

[server] Fix workspace download for GCP storage #3431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

corneliusludmann
Copy link
Contributor

Fixes #3152

How to test

start and stop a workspace, try to download the workspace

@csweichel
Copy link
Contributor

hoes does this PR relate to #3288 ?

@corneliusludmann
Copy link
Contributor Author

hoes does this PR relate to #3288 ?

That I now know the root cause for the download bug and that I now cat start with bringing this fix in #3288. It was easier to analyze this base on main because it worked there once.

@jankeromnes
Copy link
Contributor

jankeromnes commented Mar 15, 2021

/werft run

👍 started the job as gitpod-build-clu-downloading-workspaces-3152.11

@jankeromnes
Copy link
Contributor

jankeromnes commented Mar 16, 2021

Sweeper is too fast for me 🐌

/werft run

👍 started the job as gitpod-build-clu-downloading-workspaces-3152.12

Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and works like a charm! ⬇️

Many thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downloading workspaces no longer works (404 page)
3 participants