Skip to content

Conversation

geropl
Copy link
Member

@geropl geropl commented Nov 12, 2024

Description

More unit tests for prebuild selection which happens during context parsing.

Related Issue(s)

Related: CLC-913

How to test

  • see that unit tests are green

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, I left one suggestion that I'd love to get it, since it came up when I was writing new tests WRT commit histories. Thanks a lot for this!

… with actual implementation

Co-authored-by: Filip Troníček <[email protected]>
@geropl
Copy link
Member Author

geropl commented Nov 12, 2024

/unhold

@roboquat roboquat merged commit 4a70961 into main Nov 12, 2024
18 checks passed
@roboquat roboquat deleted the gpl/913-prebuild-history branch November 12, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants