Use forwardRef() for Button component #17707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While testing this, I found another issue with accepting |
easyCZ
approved these changes
May 23, 2023
gtsiolis
reviewed
May 23, 2023
There was a problem hiding this comment.
Thanks for picking this up, @selfcontained! 🌮 🌮
There was a pending community contribution which attempted to resolve this in #17326, picked up in #17430 which will close in favor of this PR.
☝️ Cross-posting here for visibility and in case there are any changes worth picking up from there. Thanks again @RayAsh37 for helping!
This means, this will also fix https://github.com/gitpod-io/gitpod/issues/16717—updated PR description to include a reference to that issue, too. 🏓
This was referenced May 23, 2023
|
/unhold |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you have the Cancel button focused in a
ConfirmationModaland click Enter, instead of canceling it, it treats it as if you confirmed, which results in a delete behavior in many scenarios. This is due to therefnot getting forwarded correctly in the<Button>component.Turns out you can't just a
refprop to a component, you need to wrap your component inforwardRef()and use therefargument it passes in. More info in the docs.Related Issue(s)
Fixes WEB-396, #16717
How to test
https://accounts.google.comfor the url, and w/e for the rest. Save it.Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh/hold