Skip to content

[dashboard] Always use these options for repository #17297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2023
Merged

[dashboard] Always use these options for repository #17297

merged 1 commit into from
May 3, 2023

Conversation

svenefftinge
Copy link
Contributor

@svenefftinge svenefftinge commented Apr 20, 2023 •
edited
Loading

Description

  • Add a checkbox, so that users don't need to always manually trigger the workspace start.
  • introduces a search param autoStart=true that allows to create Gitpod start links that auto start the workspace

Screenshot 2023-05-02 at 13 45 43

Related Issue(s)

Fixes WEB-192

How to test

Try the new option with different repositories and orgs.
Try an autostart link:
https://se-dont-ask.preview.gitpod-dev.com/?autostart=true#https://github.com/gitpod-io/gitpod

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • analytics=segment
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold

@roboquat roboquat added size/L and removed size/S labels Apr 20, 2023
@svenefftinge svenefftinge changed the title [dashboard] don't ask again on ws creation [dashboard] Always use the options for repository Apr 20, 2023
@svenefftinge svenefftinge changed the title [dashboard] Always use the options for repository [dashboard] Always use these options for repository Apr 20, 2023
@svenefftinge
Copy link
Contributor Author

we decided to wait before introducing something like this.

@svenefftinge svenefftinge reopened this May 1, 2023
@svenefftinge svenefftinge force-pushed the se/dont-ask branch 2 times, most recently from 0f12f69 to 1875151 Compare May 1, 2023 19:07
@roboquat roboquat added size/XS and removed size/L labels May 2, 2023
@svenefftinge svenefftinge reopened this May 2, 2023
@roboquat roboquat added size/L and removed size/XS labels May 2, 2023
@svenefftinge svenefftinge marked this pull request as ready for review May 2, 2023 11:39
@svenefftinge svenefftinge requested a review from a team May 2, 2023 11:39
@svenefftinge svenefftinge requested a review from gtsiolis as a code owner May 2, 2023 11:39
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label May 2, 2023
owre
owre reviewed May 2, 2023
View reviewed changes
Copy link

@owre owre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely stuff

@svenefftinge svenefftinge mentioned this pull request May 2, 2023
Closed
easyCZ
easyCZ reviewed May 2, 2023
View reviewed changes
@gtsiolis
Copy link
Contributor

gtsiolis commented May 2, 2023

Looking at this now! 👀

gtsiolis
gtsiolis approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@gtsiolis gtsiolis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX LGTM! 🌮 🌮

Left some comments below. 🏁

  • Remember review comment

Frame 1426

gtsiolis
gtsiolis reviewed May 2, 2023
View reviewed changes
Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more things! 🍷 🍷

@svenefftinge
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit c632b7e into main May 3, 2023
@roboquat roboquat deleted the se/dont-ask branch May 3, 2023 09:33
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyCZ easyCZ easyCZ approved these changes

+3 more reviewers

@mbrevoort mbrevoort mbrevoort left review comments

@gtsiolis gtsiolis gtsiolis approved these changes

@owre owre owre left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@svenefftinge @gtsiolis @mbrevoort @easyCZ @owre @roboquat