Skip to content

[dashboard] Guard subscribeToStripe against multiple calls #16890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

geropl
Copy link
Member

@geropl geropl commented Mar 17, 2023

Description

Related Issue(s)

Fixes #16524

How to test

Release Notes

NONE

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@geropl geropl requested a review from a team March 17, 2023 08:54
@geropl geropl requested a review from gtsiolis as a code owner March 17, 2023 08:54
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gpl-subscription-race.1 because the annotations in the pull request description changed
(with .werft/ from main)

@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Mar 17, 2023
@geropl geropl marked this pull request as draft March 17, 2023 08:55
@geropl geropl force-pushed the gpl/subscription-race branch from db9fe5f to 1770fca Compare March 17, 2023 09:22
@geropl geropl marked this pull request as ready for review March 17, 2023 09:25
@geropl geropl requested a review from AlexTugarev March 17, 2023 09:26
Copy link
Contributor

@selfcontained selfcontained left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't have a chance to test this on staging, as the fe dev header doesn't seem to be working for me there. I had a suggestion for the way we're using state and useEffect() though.

@geropl
Copy link
Member Author

geropl commented Mar 20, 2023

I didn't have a chance to test this on staging, as the fe dev header doesn't seem to be working for me there.

Uh, that's bad, it should!
Did you check if your user was logged in before activating the header? That's required because we limit this capability for security reasons, and the thing I regularly bump into 🙃

@geropl geropl force-pushed the gpl/subscription-race branch from 1770fca to 05d6a16 Compare March 20, 2023 09:40
@roboquat roboquat added size/L and removed size/M labels Mar 20, 2023
Copy link
Member

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change look good to me. It worked nicely so far.
Let's verify on staging after merging.

@roboquat roboquat merged commit 84e5640 into main Mar 20, 2023
@roboquat roboquat deleted the gpl/subscription-race branch March 20, 2023 15:23
@geropl
Copy link
Member Author

geropl commented Mar 20, 2023

Let's verify on staging after merging.

Did that already. 😉 But yeah, it's cheap enough, let's do it!

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/L team: webapp Issue belongs to the WebApp team
Projects
Status: In Validation
Development

Successfully merging this pull request may close these issues.

Users can create two active Stripe subscriptions, and thus receive two invoices each month
4 participants