-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Adjusting onboarding copy for better readability #16570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
started the job as gitpod-build-bmh-onboarding-copy-updates.1 because the annotations in the pull request description changed |
/werft run with-preview=true 👍 started the job as gitpod-build-bmh-onboarding-copy-updates.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/hold in case you want feedback from design
@@ -169,7 +169,7 @@ export const StepOrgInfo: FC<Props> = ({ user, onComplete }) => { | |||
<TextInputField | |||
value={jobRoleOther} | |||
onChange={setJobRoleOther} | |||
placeholder="Please specify" | |||
placeholder="Please share (optional)" | |||
hint={ | |||
jobRole === JOB_ROLE_OTHER | |||
? "Please select the role that best describes the type of work you'll use Gitpod for" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion (non-blocking): I'd suggest to remove this help text, as I don't see what additional context it provides a user.
If we do decide to keep, I'd suggest to remove the "work you'll use Gitpod for", part as:
- User likely doesn't really know what Gitpod is
- We have the other field later on for the purpose
? "Please select the role that best describes the type of work you'll use Gitpod for" | |
? "Please select the role which best describes your profession" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I'll drop the hint completely from this.
{ value: "team-lead", label: "Team / Function Lead" }, | ||
{ value: "academics", label: "Academia (Student, Researcher)" }, | ||
{ value: "enabling", label: "Platform or Developer Experience" }, | ||
{ value: "team-lead", label: "A Team or Function Lead role" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion(non-blocking): Could we add "lead" after team lead? I noticed some people submitted "team lead" in other, but did not notice here, my theory is because we say "team / function lead" so on scanning "team lead" does not appear.
{ value: "team-lead", label: "A Team or Function Lead role" }, | |
{ value: "team-lead", label: "A Team Lead or Function Lead role" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clean up changes, Brad ! 🙏
/werft run with-preview=true 👍 started the job as gitpod-build-bmh-onboarding-copy-updates.3 |
d6e4416
to
c4b306b
Compare
/unhold |
Description
Adjusting some of the copy on the final step of onboarding to help readability.
How to test
Release Notes
Documentation
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
leeway-target=components:all
Run Leeway with
--dont-test
Publish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh