[db] long running migration for filling the organizationid in workspaces #16269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenefftinge
force-pushed
the
se/migration-orgid-ws
branch
from
8255076 to
9751876
Compare
3 tasks
svenefftinge
changed the title
roboquat
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
|
started the job as gitpod-build-se-migration-orgid-ws.2 because the annotations in the pull request description changed |
|
/werft run with-clean-slate-deployment 👍 started the job as gitpod-build-se-migration-orgid-ws.3 |
|
/hold |
easyCZ
reviewed
Feb 9, 2023
components/gitpod-db/src/long-running-migration/long-running-migration.ts
Outdated
Show resolved
Hide resolved
svenefftinge
force-pushed
the
se/workspace-gets-orgid
branch
2 times, most recently
from
d3b0ed9 to
4de3f40
Compare
svenefftinge
force-pushed
the
se/migration-orgid-ws
branch
from
9751876 to
4bf7d78
Compare
svenefftinge
force-pushed
the
se/migration-orgid-ws
branch
from
4bf7d78 to
da771a6
Compare
easyCZ
reviewed
Feb 10, 2023
Comment on lines
+61
to
+77
| log.info(`Running long running migration '${migration.getName()}' ...`); | ||
| const now = new Date(); | ||
| try { | ||
| const completed = await migration.runMigrationBatch(); | ||
| log.info( | ||
| `Long running migration ${migration.getName()} took ${new Date().getTime() - now.getTime()}ms`, | ||
| { completed }, | ||
| ); | ||
| migrationMetaData.completed = completed; | ||
| } catch (e) { | ||
| log.error(`Long running migration ${migration.getName()} failed`, e); | ||
| } | ||
| allCompleted = allCompleted && migrationMetaData.completed; | ||
| migrationMetaData.lastRun = new Date(); | ||
| await repo.save(migrationMetaData); | ||
| } | ||
| return allCompleted; |
There was a problem hiding this comment.
As a follow-up, it would be nice to export a metric if the batch+job failed, or succeeded such that we can check, or setup alerting for these. This would be in particular useful for Dedicated, where we don't have access to logs.
easyCZ
approved these changes
Feb 10, 2023
|
/unhold |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a long-running migration and small service that manages and executes it.
This relies on new workspaces getting an organizationId see #16261
Related Issue(s)
See #16177
How to test
Release Notes
Documentation
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
leeway-target=components:all
Run Leeway with
--dont-testPreview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh