[server] added UpdateTeam #15749
Closed
[server] added UpdateTeam #15749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenefftinge
force-pushed
the
sefftinge/allow-users-to-rename-5067
branch
2 times, most recently
from
affae41 to
da72dae
Compare
|
started the job as gitpod-build-sefftinge-allow-users-to-rename-5067.4 because the annotations in the pull request description changed |
|
/hold |
easyCZ
reviewed
Jan 16, 2023
| @@ -122,6 +122,18 @@ export class TeamDBImpl implements TeamDB { | |||
| return soleOwnedTeams; | |||
| } | |||
|
|
|||
| public async updateTeam(team: Partial<Team>): Promise<Team> { | |||
There was a problem hiding this comment.
The signature here is possibly misleading. You can only update the team name, but you can pass in the whole team. Does it make sense to be explicit with which fields are acceptable?
There was a problem hiding this comment.
Do we need to also check the team name is not empty? Currently I could set the name to empty
| throw new ResponseError(ErrorCodes.NOT_FOUND, `Team ${team.id} does not exist`); | ||
| } | ||
| const members = await this.teamDB.findMembersByTeam(teamId); | ||
| await this.guardAccess({ kind: "team", subject: existingTeam, members }, "update"); |
There was a problem hiding this comment.
For others reading this, the update action is only allowed if you're the team owner.
svenefftinge
force-pushed
the
sefftinge/allow-users-to-rename-5067
branch
from
da72dae to
1c90cb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an updateTeam call to the server component.
Related Issue(s)
See #5067
How to test
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh