Skip to content

[public-api] Implement ProjectsService.DeleteProject #15197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 8, 2022
Merged

[public-api] Implement ProjectsService.DeleteProject #15197

merged 2 commits into from
Dec 8, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Dec 6, 2022 •
edited
Loading

Description

Related Issue(s)

How to test

  1. Preview
  2. Create a project
  3. Delete the project
  4. Observe project is deleted
  5. Observe request (in the Network tab) was made against the Public API

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold for dependency on #14938

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-mp-papi-projects-delete.1 because the annotations in the pull request description changed
(with .werft/ from main)

@roboquat roboquat added the size/M label Dec 6, 2022
@easyCZ easyCZ force-pushed the mp/papi-projects-delete branch from 96e3f7e to e4ac3fc Compare December 6, 2022 20:14
@roboquat roboquat added size/XXL and removed size/M labels Dec 6, 2022
@easyCZ easyCZ changed the base branch from main to mp/dash-list-projects-public-api December 6, 2022 20:14
@easyCZ easyCZ force-pushed the mp/dash-list-projects-public-api branch from f6d4908 to 9dd4269 Compare December 6, 2022 20:15
@easyCZ easyCZ force-pushed the mp/papi-projects-delete branch from e4ac3fc to 0a841df Compare December 6, 2022 20:16
@roboquat roboquat added size/M and removed size/XXL labels Dec 6, 2022
@gitpod-io gitpod-io deleted a comment from github-actions bot Dec 6, 2022
Base automatically changed from mp/dash-list-projects-public-api to main December 7, 2022 11:03
@roboquat roboquat added size/L and removed size/M labels Dec 7, 2022
@easyCZ easyCZ force-pushed the mp/papi-projects-delete branch from 0a841df to 5480bf2 Compare December 7, 2022 11:55
@roboquat roboquat removed the size/L label Dec 7, 2022
@easyCZ easyCZ marked this pull request as ready for review December 7, 2022 11:55
@easyCZ easyCZ requested a review from a team December 7, 2022 11:55
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Dec 7, 2022
@easyCZ easyCZ force-pushed the mp/papi-projects-delete branch from 5480bf2 to 4772d38 Compare December 7, 2022 12:59
@roboquat roboquat merged commit 2c3cdce into main Dec 8, 2022
@roboquat roboquat deleted the mp/papi-projects-delete branch December 8, 2022 15:01
@roboquat roboquat added the deployed: webapp Meta team change is running in production label Dec 9, 2022
@roboquat roboquat added the deployed Change is completely running in production label Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laushinka laushinka laushinka approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Delete Project and use it in Dashboard
3 participants
@easyCZ @laushinka @roboquat