Skip to content

[dashboard] List projects using Public API #14938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Nov 24, 2022

Description

Behind a feature flag, list projects using Public API

Related Issue(s)

Fixes #14896

How to test

Preview

  1. Add a project
  2. See the project is listed
  3. Check request is made against Public API

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-mp-dash-list-projects-public-api.1 because the annotations in the pull request description changed
(with .werft/ from main)

@easyCZ easyCZ changed the title [dash] Add feature flag for Experimental Projects Service [dashboard] List projects using Public API Nov 24, 2022
@easyCZ easyCZ force-pushed the mp/dash-list-projects-public-api branch from 2fd6864 to 2510c42 Compare November 24, 2022 19:32
@easyCZ easyCZ changed the base branch from mp/dash-use-projects-service-flag to main November 24, 2022 19:32
@easyCZ easyCZ force-pushed the mp/dash-list-projects-public-api branch from 2510c42 to db3219b Compare November 24, 2022 19:33
@easyCZ easyCZ marked this pull request as ready for review November 24, 2022 19:34
@easyCZ easyCZ requested a review from a team November 24, 2022 19:34
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Nov 24, 2022
@easyCZ easyCZ marked this pull request as draft November 24, 2022 20:01
@easyCZ easyCZ force-pushed the mp/dash-list-projects-public-api branch from 5f053a4 to 0d556f0 Compare November 25, 2022 11:55
@easyCZ easyCZ force-pushed the mp/dash-list-projects-public-api branch 4 times, most recently from 3f0fde0 to f6d4908 Compare December 6, 2022 16:05
@easyCZ
Copy link
Member Author

easyCZ commented Dec 6, 2022

/werft run

👍 started the job as gitpod-build-mp-dash-list-projects-public-api.14
(with .werft/ from main)

@easyCZ easyCZ marked this pull request as ready for review December 6, 2022 19:45
@@ -1540,7 +1540,7 @@ func (gp *APIoverJSONRPC) CreateProject(ctx context.Context, options *CreateProj
return
}
_params := []interface{}{options}
err = gp.C.Call(ctx, string(FunctionCreateProject), _params, nil)
err = gp.C.Call(ctx, string(FunctionCreateProject), _params, &res)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We forgot to include these originally, which resulted in the API call always returning nil

@easyCZ easyCZ force-pushed the mp/dash-list-projects-public-api branch from f6d4908 to 9dd4269 Compare December 6, 2022 20:15
@roboquat roboquat merged commit 5400e26 into main Dec 7, 2022
@roboquat roboquat deleted the mp/dash-list-projects-public-api branch December 7, 2022 11:03
@roboquat roboquat added the deployed: webapp Meta team change is running in production label Dec 8, 2022
@roboquat roboquat added the deployed Change is completely running in production label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement ListProjects
3 participants