-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[ubp] allow usage of team without stripe sub #15159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
started the job as gitpod-build-sefftinge-ubp-unbilled-teams-with-15137.1 because the annotations in the pull request description changed |
eca4739
to
b7b045f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @svenefftinge!
So I guess we now always show the "Balance" UI also for Teams (even when they don't have any credits):
0 credit limit (default for teams without sub) | credit limit almost used up |
---|---|
![]() |
![]() |
Side note: This is a pre-existing change, but I still have a hard time reading the "reverse progress bar" that's showing "remaining balance" instead of just "credits consumed".
- When the credit limit is 0, it shows a full progress bar (i.e. "everything remains"), while I would expect an empty progress bar instead (i.e. "nothing remains")
- Also, over time as you consume credits, the progress bar goes from full to empty, i.e. it "shrinks" from right to left 🙈 I find this super confusing
So, the new supported behavior with this PR is:
- Take a team without a Stripe subscription
- Increase its monthly limit via Admin
- The team is now able to take attribution for its own projects 🙌
Caveats:
- Still, once a team has an altered limit, users can not default their own attribution to that team in their
/billing
section (teams still need a subscription to be a default attribution) - Also, once your altered team has reached its limit, you can still start new workspaces for that team's project -- it's just that the new workspaces will silently re-attribute to the user instead of the team (I found that a little confusing)
/hold for the caveats, but approving because this works as advertised and allows granting more resources to a team
Cc @jldec and @gtsiolis because this makes Team Billing always show the "Balance" UI, even when they don't have a subscription (small UX change)
/unhold will take care of the caveats in follow up |
Description
This change removes the requirement for a team to have an active stripe subscription in order to see their balance and start workspaces.
It only depends on whether they have credits available. This change allows to grant a spending limit and/or credits to teams that are still on the internal
other
strategy.Related Issue(s)
Fixes #15137
How to test
Release Notes
Documentation
Werft options:
If enabled this will build
install/preview
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh