Skip to content

[usage] support multiple entries on invoices #15145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

svenefftinge
Copy link
Member

@svenefftinge svenefftinge commented Dec 5, 2022

Description

Allow invoices with multiple items.

The plans for individuals have a fixed amount of credits, which results in multi-line invoices (see test data).

Related Issue(s)

Fixes #15134

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@svenefftinge svenefftinge requested a review from a team December 5, 2022 08:52
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Dec 5, 2022
@easyCZ
Copy link
Member

easyCZ commented Dec 5, 2022

Under what scenarios do we receive multiple items on the invoice?

@svenefftinge svenefftinge force-pushed the sefftinge/ubp-webhook-error-in-15134 branch from 19b5c00 to 6d7c9b1 Compare December 5, 2022 11:38
@svenefftinge
Copy link
Member Author

Under what scenarios do we receive multiple items on the invoice?

The plans for individuals have a fixed amount of credits, which results in additional line items on the invoice (see test data).

Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarification. At the time of my review, the issue didn't contain any back references so hence the question about context.

@roboquat roboquat merged commit 797c1b7 into main Dec 5, 2022
@roboquat roboquat deleted the sefftinge/ubp-webhook-error-in-15134 branch December 5, 2022 11:44
@svenefftinge
Copy link
Member Author

svenefftinge commented Dec 5, 2022

At the time of my review, the issue didn't contain any back references so hence the question about context.

Yes, sorry for that ... have been a bit in a hurry 😬

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XL team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UBP] webhook error in usage component - Invoice did not contain exactly 1 line item
3 participants