-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[installer] Add slow-server
to network policy ingress rules
#15106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
started the job as gitpod-build-af-slow-workspace-starts.15 because the annotations in the pull request description changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and sounds valid!
Just FYI, there seem to be more NetworkPolicy rules that are present with component: server
to allow communication with components like proxy
, etc. Might be a good idea to add now (or alter when we see the need).
Allow ingress to `usage` from `slow-server`.
Allow ingress to `image-builder-mk3` from `slow-server`.
3604f30
to
5c7f28f
Compare
Thanks for the review @Pothulapati.
Looking at the network policy docs, each of the above policies allows ingress from a pod called Is it possible that the policies are incorrect and we made the mistake described in the docs, ie that those parts of the policies should in fact read: - namespaceSelector:
matchLabels:
chart: monitoring
- podSelector:
matchLabels:
app: gitpod
component: server To allow ingress from anywhere in a Do you have any idea what the intention is with these policies? |
/unhold because the changes here are sufficient to start workspaces through |
Description
As part of #9198, a deployment called
slow-server
was added, identical toserver
but with a higher latency connection to the database.This PR adds the
slow-server
component to theimage-builder-mk3
andusage
component network policy ingress rules, so that ingress to those two components works forslow-server
just as it does for theserver
component.This means that workspace startup works correctly for workspaces started by
slow-server
.Related Issue(s)
Fixes #15027
How to test
slow_database
(non-production) feature flag for your user id./api/feature-flags/slow-database
starts settingX-Gitpod-Slow-Database: true
in the response headers.The workspace start should be slower than usual, but should complete successfully.
Release Notes
Documentation
Werft options:
If enabled this will build
install/preview
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh