Skip to content

[dashboard] Remove client side eval of slow_database flag #15036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

andrew-farries
Copy link
Contributor

Description

Reverts #14752.

The logic of checking the feature flag has moved (in #15035) to the backend (proxy) so we don't need this logic on the dashboard anymore.

Related Issue(s)

Part of #9198 and #14964.

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

The logic of checking the feature flag has moved to the backend
(`proxy`) so we don't need this logic on the dashboard anymore.
@andrew-farries andrew-farries requested a review from a team November 29, 2022 13:36
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Nov 29, 2022
@roboquat roboquat merged commit fbd0fe5 into main Nov 29, 2022
@roboquat roboquat deleted the af/remove-dashboard-feature-flag branch November 29, 2022 14:21
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants