[proxy] Add latency to all websocket connections to server #15035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the returned `X-Gitpod-Slow-Database` header to direct the ws connection to either the `slow-server` or `server` deployment.
|
started the job as gitpod-build-af-add-latency-to-ws-connections.16 because the annotations in the pull request description changed |
4 tasks
easyCZ
approved these changes
Nov 29, 2022
5 tasks
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #14778 and #14752, latency was added to websocket connections to
serverfrom the dashboard by testing the value of theslow_databasefeature flag on the client side and setting an appropriate header during the websocket connection upgrade handshake.This approach works for connections to
serverfrom the dashboard but not for other websocket connections toserver.This PR moves the evaluation of the feature flag from the dashboard client to
proxy, using a 'pre-flight' check just like the one added in #14960 for regular HTTP requests toserver/api*requests.The client side code to check the value of the feature flag will be removed by #15035.
Related Issue(s)
Part of #9198
Closes #14964
How to test
When the
slow_databasefeature flag is enabled for your user id in the preview environment, websocket connections from dashboard are still subject to extra latency.Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh