Skip to content

[dashboard] fix condition for workspace classes #14803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2022
Merged

Conversation

svenefftinge
Copy link
Contributor

@svenefftinge svenefftinge commented Nov 20, 2022

Description

Fix the condition for when to show the select workspace class setting on projects

Related Issue(s)

Fixes #14800

How to test

Create a project starting with "Gitpod" and verify that the setting is visible.
Create a project not starting with "Gitpod" and verify that the setting is not visible.

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-payment
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-se-cond-ws-class.1 because the annotations in the pull request description changed
(with .werft/ from main)

@svenefftinge svenefftinge marked this pull request as ready for review November 20, 2022 19:08
@svenefftinge svenefftinge requested a review from a team November 20, 2022 19:08
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Nov 20, 2022
@roboquat roboquat merged commit f5a67af into main Nov 20, 2022
@roboquat roboquat deleted the se/cond-ws-class branch November 20, 2022 20:36
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SelectWorkspaceClass in ProjectSettings should not depend on PVC feature flag
3 participants