[ws-manager] Remove wait from probes #14768
Conversation
[ws-manager] Remove wait from probes
|
started the job as gitpod-build-aledbf-wswait.1 because the annotations in the pull request description changed |
|
/werft run 👍 started the job as gitpod-build-aledbf-wswait.2 |
aledbf
force-pushed
the
aledbf/wswait
branch
from
6c1d251 to
f21e9d1
Compare
Remove invalid tag
| @@ -42,7 +42,7 @@ type WorkspaceReadyProbe struct { | |||
|
|
|||
| // NewWorkspaceReadyProbe creates a new workspace probe | |||
| func NewWorkspaceReadyProbe(workspaceID string, workspaceURL url.URL) WorkspaceReadyProbe { | |||
| workspaceURL.Path += "/_supervisor/v1/status/ide/wait/true" | |||
| workspaceURL.Path += "/_supervisor/v1/status/ide" | |||
There was a problem hiding this comment.
@iQQBot what do you think about removing wait/true? I ask because you initially authored #13828. Is there anything you'd recommend we explicitly test?
I ask because @utam0k did some testing here which is related.
There was a problem hiding this comment.
I think the problem before was that ws-manager was only looking at HTTP status codes from the supervisor and didn't validate the body. I think this would increase the number of requests, is that the intent?
There was a problem hiding this comment.
remove wait/true has no obvious benefit other than increasing the number of requests
Description
Partially reverts #13828 to not wait in probe
Release Notes
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh