Skip to content

[ws-manager] Do not follow redirect when ready probe #13828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 13, 2022
Merged

[ws-manager] Do not follow redirect when ready probe #13828

merged 4 commits into from
Oct 13, 2022

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Oct 13, 2022 •
edited
Loading

Description

This PR fixes some issue from ws-manager

  1. ws-manager do not follow redirect when it run ide ready probe
  2. ws-manager will check ide ready response, it include ok status
  3. using /_supervisor/v1/status/ide/wait/true API in order to reduce request

And do some minor change for integration test

  1. using workspaceId as servicePrefix, because ws-proxy will check the hostname regex
  2. refactor some workspace integration-test, to make it pass

Related Issue(s)

Fixes #

How to test

integration test should pass

  1. start a workspace in preview environment, it should work as before

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=workspace
    Valid options are all, workspace, webapp, ide

@iQQBot iQQBot changed the title [ws-proxy] Do not follow redirect when ready probe [ws-manager] Do not follow redirect when ready probe Oct 13, 2022
@roboquat roboquat added size/M and removed size/XS labels Oct 13, 2022
@roboquat roboquat added size/L and removed size/M labels Oct 13, 2022
@iQQBot iQQBot mentioned this pull request Oct 13, 2022
Closed
3 tasks
@iQQBot
Copy link
Contributor Author

iQQBot commented Oct 13, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-pd-fix-ide-probe.7
(with .werft/ from main)

@gitpod-io gitpod-io deleted a comment from werft-gitpod-dev-com bot Oct 13, 2022
@iQQBot iQQBot marked this pull request as ready for review October 13, 2022 15:49
@iQQBot iQQBot requested a review from a team October 13, 2022 15:49
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Oct 13, 2022
@roboquat roboquat merged commit b99f7b9 into main Oct 13, 2022
@roboquat roboquat deleted the pd/fix-ide-probe branch October 13, 2022 16:13
@kylos101
Copy link
Contributor

Thank you @iQQBot !

cc: @utam0k for 👀

This was referenced Oct 13, 2022
Merged
Closed
@aledbf aledbf mentioned this pull request Oct 18, 2022
Merged
3 tasks
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Oct 19, 2022
@geropl geropl mentioned this pull request Oct 22, 2022
Closed
utam0k pushed a commit that referenced this pull request Nov 17, 2022
revert #13828
58ab5fa
@aledbf aledbf mentioned this pull request Nov 17, 2022
Closed
4 tasks
@utam0k utam0k mentioned this pull request Dec 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledbf aledbf aledbf approved these changes

Assignees

@aledbf aledbf

Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/L team: workspace Issue belongs to the Workspace team
Projects
No open projects
🌌 Workspace Team
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iQQBot @kylos101 @aledbf @roboquat