Skip to content

fix admin search #14514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2022
Merged

fix admin search #14514

merged 1 commit into from
Nov 8, 2022

Conversation

svenefftinge
Copy link
Contributor

@svenefftinge svenefftinge commented Nov 8, 2022

Description

Fixes the broken admin search

Related Issue(s)

Fixes #13749

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-sefftinge-admin-dashboard-pagination-13749.1 because the annotations in the pull request description changed
(with .werft/ from main)

@svenefftinge svenefftinge force-pushed the sefftinge/admin-dashboard-pagination-13749 branch from 6fffae0 to 4e593da Compare November 8, 2022 12:27
@svenefftinge svenefftinge marked this pull request as ready for review November 8, 2022 12:27
@svenefftinge svenefftinge requested a review from a team November 8, 2022 12:27
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Nov 8, 2022
@easyCZ
Copy link
Member

easyCZ commented Nov 8, 2022

What was the problem in the original? I'm failing to see where exactly the fix is.

@svenefftinge
Copy link
Contributor Author

What was the problem in the original? I'm failing to see where exactly the fix is.

The currentPage state was not updated when it was used in search (react state doesn't update sync)

Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the clarification on what the issue was.

@roboquat roboquat merged commit 0633cdf into main Nov 8, 2022
@roboquat roboquat deleted the sefftinge/admin-dashboard-pagination-13749 branch November 8, 2022 13:09
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin dashboard pagination is broken
3 participants