Inject new IApplicationCluster dependency into server and wsman-bridge
#14084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an IApplicationClusterProvider interface an inject an implementation into WorkspaceManagerClientProvider. This will be used to let the WorkspaceManagerClientProvider know in which application cluster it runs. By injecting a new dependency, we can do the environment variable check once at the top of the object composition graph.
|
started the job as gitpod-build-af-bind-application-cluster-provider.8 because the annotations in the pull request description changed |
3 tasks
geropl
reviewed
Oct 21, 2022
|
|
||
| function newApplicationClusterProvider(): IApplicationClusterProvider { | ||
| return { | ||
| getApplicationCluster: () => process.env.GITPOD_INSTALLATION_SHORTNAME ?? "", |
There was a problem hiding this comment.
Can we read from Config here? See here for an example.
|
closing after discussion of a different approach with @geropl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create a new
IApplicationClusterProviderinterface and inject implementations intoWorkspaceManagerClientProvider.The injected implemenations will be used to let the
WorkspaceManagerClientProviderknow in which application cluster it runs.By injecting a new dependency, we can do the environment variable check once at the top of the object composition graph rather than having to read the environment in multiple places lower down the object graph.
Related Issue(s)
Part of #9198 and #13800
How to test
No behaviour change - all tests pass and workspaces start as before.
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide