Skip to content

[preview] Fix broken shortname assignment in preview envs #13953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

andrew-farries
Copy link
Contributor

@andrew-farries andrew-farries commented Oct 18, 2022

Description

Fix the broken installation short name in preview environments.

The commit was cherry-picked from a larger PR (#13866).

Related Issue(s)

Indirectly related to #13800.

How to test

In the preview environment run:

kubectl exec deploy/ws-manager-bridge -- env | grep GITPOD_INSTALLATION_SHORTNAME

The value is set to "dev" as opposed to "".

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pulling this out! ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants