Skip to content

[public-api] Authentication interceptors for connect API #13693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Oct 8, 2022

Description

Adds authentication interceptors for connect API on public-api.

This is a pre-cursor to refactoring existing handlers to use connect.

Related Issue(s)

How to test

  • Unit tests
➜ curl \
    --header 'Content-Type: application/json' \
    --data '{"workspaceId": "123"}' \
    https://api.mp-public-8c1701f31b.preview.gitpod-dev.com/gitpod.v1.WorkspacesService/GetWorkspace | jq

{
  "code": "unauthenticated",
  "message": "empty authorization header: missing access token"
}

➜ curl \
    --header 'Content-Type: application/json' \
    --header 'Authorization: Bearer foo' \
    --data '{"workspaceId": "123"}' \
    https://api.mp-public-8c1701f31b.preview.gitpod-dev.com/gitpod.v1.WorkspacesService/GetWorkspace | jq

{
  "code": "unimplemented",
  "message": "gitpod.v1.WorkspacesService.GetWorkspace is not implemented"
}

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@easyCZ easyCZ requested a review from a team October 8, 2022 21:55
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Oct 8, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-mp-public-api-connect-auth.2 because the annotations in the pull request description changed
(with .werft/ from main)

@easyCZ easyCZ force-pushed the mp/public-api-connect-auth branch from bcbb27d to 6755ce7 Compare October 8, 2022 22:15
@easyCZ easyCZ force-pushed the mp/public-api-connect-auth branch from 6755ce7 to d7b5c50 Compare October 9, 2022 20:09
@roboquat roboquat merged commit 46d734e into main Oct 10, 2022
@roboquat roboquat deleted the mp/public-api-connect-auth branch October 10, 2022 14:54
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XL team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants