[proxy] Handle both gRPC and HTTP requests against public-api #13582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-mp-caddy-route-http-1-to-api.1 because the annotations in the pull request description changed |
easyCZ
commented
Oct 4, 2022
| @@ -62,6 +62,9 @@ func Start(logger *logrus.Entry, version string, cfg *config.Configuration) erro | |||
| log.Info("No stripe webhook secret is configured, endpoints will return NotImplemented") | |||
| } | |||
|
|
|||
| srv.HTTPMux().Handle("/test", http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | |||
| w.Write([]byte(`test`)) | |||
There was a problem hiding this comment.
We'll remove this once we've got actual endpoints implemented, for now this acts as a quick check the server is reachable.
easyCZ
force-pushed
the
mp/caddy-route-http-1-to-api
branch
from
ae505c4 to
ea5f5c4
Compare
easyCZ
changed the title
andrew-farries
approved these changes
Oct 5, 2022
9 tasks
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
How to test
Ensure that gRPC traffic is still routed to the gRPC server
Permission denied is expected, we're supplying a dummy token. But we got an application level response - this means it works.
Test that HTTP routing works to the HTTP server
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide