Skip to content

[dashboard] (pagination) make sure next page is selectable #12809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2022
Merged

[dashboard] (pagination) make sure next page is selectable #12809

merged 1 commit into from
Sep 9, 2022

Conversation

AlexTugarev
Copy link
Member

@AlexTugarev AlexTugarev commented Sep 9, 2022 •
edited
Loading

Description

Fixes pagination, where the page next to current was not selectable.

Related Issue(s)

Fixes #12804

How to test

cd components/dashboard
yarn test:unit getPagination

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview
  • /werft with-payment

@AlexTugarev AlexTugarev requested a review from a team September 9, 2022 10:09
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Sep 9, 2022
andrew-farries
andrew-farries suggested changes Sep 9, 2022
View reviewed changes
gtsiolis
gtsiolis approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't test this in a preview environment but from the tests added here UX looks great!

@AlexTugarev AlexTugarev force-pushed the alex/usage-list-pagination-does-12804 branch from 598278c to 956487c Compare September 9, 2022 11:11
@AlexTugarev
Copy link
Member Author

@andrew-farries, please have a second look at it!

@AlexTugarev
Copy link
Member Author

/hold

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-alex-usage-list-pagination-does-12804.2 because the annotations in the pull request description changed
(with .werft/ from main)

@AlexTugarev
Copy link
Member Author

/hold cancel

@AlexTugarev AlexTugarev force-pushed the alex/usage-list-pagination-does-12804 branch from 956487c to 4f8bee3 Compare September 9, 2022 13:48
@roboquat roboquat merged commit 6a373fa into main Sep 9, 2022
@roboquat roboquat deleted the alex/usage-list-pagination-does-12804 branch September 9, 2022 14:03
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtsiolis gtsiolis gtsiolis approved these changes

@andrew-farries andrew-farries andrew-farries approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Usage list pagination does not advance to current page
4 participants
@AlexTugarev @gtsiolis @andrew-farries @roboquat