Skip to content

Show Team Seats that block individuals from being in the Usage-Based Free tier #12805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2022

Conversation

geropl
Copy link
Member

@geropl geropl commented Sep 9, 2022

Description

If users are already member of a paid Chargebee team, and not part of a UBP team yet, their move to UBP (free tier) is blocked. This PR shows the team names of those who are actually blocking.
We can use this in two ways:

  1. understand their state better ourselves when operating Gitpod (admin dashboard)
  2. explain in the docs how people can understand themselves (personal billing page)

Related Issue(s)

Fixes #12758

How to test

image

image

Release Notes

display the team names which block upgrade to the UBP free tier

Documentation

Werft options:

  • /werft with-preview
  • /werft with-payment
  • /werft with-clean-slate-deployment

@geropl
Copy link
Member Author

geropl commented Sep 9, 2022

/werft run

👍 started the job as gitpod-build-gpl-12758-list-plans.2
(with .werft/ from main)

@geropl geropl force-pushed the gpl/12758-list-plans branch from e018679 to 450dbee Compare September 9, 2022 13:48
@roboquat roboquat added size/M and removed size/XS labels Sep 9, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gpl-12758-list-plans.4 because the annotations in the pull request description changed
(with .werft/ from main)

@geropl
Copy link
Member Author

geropl commented Sep 9, 2022

/werft run

👍 started the job as gitpod-build-gpl-12758-list-plans.5
(with .werft/ from main)

@geropl geropl force-pushed the gpl/12758-list-plans branch 2 times, most recently from bb0b809 to 196e907 Compare September 23, 2022 14:18
@geropl geropl changed the title dev Show Team Seats that block individuals from being in the Usage-Based Free tier Sep 23, 2022
@jldec jldec added the team: webapp Issue belongs to the WebApp team label Oct 2, 2022
@stale
Copy link

stale bot commented Oct 14, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Oct 14, 2022
@stale stale bot closed this Oct 20, 2022
@jldec jldec reopened this Oct 20, 2022
@geropl geropl force-pushed the gpl/12758-list-plans branch from 196e907 to 253cf56 Compare October 26, 2022 09:04
@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Oct 26, 2022
@geropl geropl force-pushed the gpl/12758-list-plans branch from 253cf56 to 19aa7da Compare October 26, 2022 09:17
@geropl geropl marked this pull request as ready for review October 26, 2022 13:51
@geropl geropl requested a review from a team October 26, 2022 13:51
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gpl-12758-list-plans.10 because the annotations in the pull request description changed
(with .werft/ from main)

@roboquat roboquat added size/L and removed size/M labels Oct 26, 2022
@geropl
Copy link
Member Author

geropl commented Oct 26, 2022

@gtsiolis It would be awesome if you could have a look at the visual changes. Happy to take up any none-trivial changes in a follow-up.

But do note that this is 1.) a very temporary problem, 2.) for only a subset of our users, so not worth investing tons of time into. 🧘

@gtsiolis
Copy link
Contributor

gtsiolis commented Oct 27, 2022

Looking at this now! 👀

Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this, @geropl! 🔮

This could probably also resolve #3948 and #5977. 🏓 🏓

Feels like this PR is tackling two things in one step, which could increase the scope of changes and review time, however the size of code changes looks like an MVC! 🛹

Left some thoughts and comments, let's open any follow-up issue for any of the suggestion that significantly increase the scope of the changes or time to merge this. ⏱️

(userBillingMode.teamNames || []).map((tn) => <li>{tn}</li>)}
</ul>
</InfoBox>
)}
<InfoBox className="w-2/3 mt-14 mx-auto">
If you are interested in purchasing a plan for a team, purchase a Team plan with one centralized
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Since team plans are no longer available and team billing is the only option available for new teams, does it make sense to drop this nudge here altogether?

@geropl
Copy link
Member Author

geropl commented Oct 27, 2022

Thanks for tackling this, @geropl! crystal_ball

@gtsiolis Thx for your comments, super helpful as usual 🙏

Let me fix the "always show assigned teams", and some of our suggestions (especially this one) in a follow-up next week.

@geropl geropl force-pushed the gpl/12758-list-plans branch from c1d4bd1 to 18151c7 Compare November 4, 2022 15:47
@geropl
Copy link
Member Author

geropl commented Nov 7, 2022

/werft run

👍 started the job as gitpod-build-gpl-12758-list-plans.13
(with .werft/ from main)

@geropl geropl force-pushed the gpl/12758-list-plans branch from 18151c7 to 72ea0ee Compare November 7, 2022 15:06
@roboquat roboquat merged commit 88fa55e into main Nov 7, 2022
@roboquat roboquat deleted the gpl/12758-list-plans branch November 7, 2022 15:57
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/L team: webapp Issue belongs to the WebApp team
Projects
Status: In Validation
Development

Successfully merging this pull request may close these issues.

BillingMode: If you're blocked to reach UBP by Team Seats/Team Subscriptions: Render Owner/Team Names in Billing(+ Admin) UI
5 participants