-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[terraform] Add k3s setup for tests #12794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
64c29b0
to
8534624
Compare
d249e8c
to
8e1c991
Compare
8534624
to
537f140
Compare
537f140
to
4eaa675
Compare
af40a33
to
4cbe4bc
Compare
|
4cbe4bc
to
3839c20
Compare
3839c20
to
92dae86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, didn't submit this review! Sorry for the delay!
The only major change is switching a couple of cases from var.credentials
to local.credentials_path
. Also it seems like switching these variables around to pass credentials as a variable while introducing credentials_path
is incurring more pain than I expected; if it continues to hurt we can just revert that change and pass around a file path.
There's some touch ups we can land around make output
but we can address that in another PR.
Since this has been taking longer to review/merge than I like I'm approving this now, amend as you see fit. Thanks for your patience!
/hold for above, merge at your discretion
credentials = var.credentials_path | ||
kubeconfig = var.kubeconfig | ||
dns_sa_creds = var.credentials_path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
credentials = var.credentials_path | |
kubeconfig = var.kubeconfig | |
dns_sa_creds = var.credentials_path | |
credentials = local.credentials | |
kubeconfig = var.kubeconfig | |
dns_sa_creds = local.credentials |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The k3s
module expects the file path and not the JSON content itself. This change would break the module
@@ -0,0 +1,20 @@ | |||
terraform { | |||
backend "gcs" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: We should look into using terraform init -backend-config
so that the GCS backend can be adjusted without having to amend a version controlled file.
No action needed.
e9b0eef
to
614de8f
Compare
Co-authored-by: Adrien Thebo <[email protected]>
614de8f
to
71174dc
Compare
/unhold |
Description
This PR adds a very rough single-cluster setup for k3s. We are adding this for consistency with Azure, AWS and GCP setups so we can consistently run the tests. We do not recommend users to use this because the underlying module still make use of
k3sup
and we have plans to move tok3s
before suggesting this as a solution. Hence we have not included a Readme with this directory.Related Issue(s)
Fixes #12866
How to test
install/infra/single-cluster/k3s
.main.tf
to have the right bucket name.terraform.tfvars
to right parameters for the cluster.Then run:
Release Notes
Documentation
Werft options: