Skip to content

Update go to v1.19 #11891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 8, 2022
Merged

Update go to v1.19 #11891

merged 2 commits into from
Aug 8, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 4, 2022 •
edited
Loading

How to test

  • Open a workplace using this pull request
  • Run go version
  • Check the returned value is go version go1.19 linux/amd64

Release Notes

NONE

Werft options:

  • /werft with-preview

@aledbf
ac61063 
Update go to v1.19
@aledbf
7bcaa14 
Update dev-environment image
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

@roboquat roboquat added size/M and removed size/XS labels Aug 4, 2022
@aledbf aledbf marked this pull request as ready for review August 4, 2022 21:29
@aledbf aledbf requested review from a team August 4, 2022 21:29
@github-actions github-actions bot added team: IDE team: devx team: delivery Issue belongs to the self-hosted team team: workspace Issue belongs to the Workspace team labels Aug 4, 2022
sagor999
sagor999 approved these changes Aug 4, 2022
View reviewed changes
.gitpod.yml
@@ -1,4 +1,4 @@
image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:af-install-evans-in-base-image.1
image: eu.gcr.io/gitpod-core-dev/dev/dev-environment:aledbf-go.18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image says go.18... 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's the number of the build ¯_(ツ)_/¯

@aledbf aledbf self-assigned this Aug 4, 2022
@andreafalzetti andreafalzetti self-requested a review August 8, 2022 09:00
Pothulapati
Pothulapati approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@roboquat roboquat merged commit 78b4ac7 into main Aug 8, 2022
@roboquat roboquat deleted the aledbf/go branch August 8, 2022 10:29
@andrew-farries andrew-farries mentioned this pull request Aug 8, 2022
Merged
1 task
@roboquat roboquat added deployed: IDE IDE change is running in production deployed: workspace Workspace team change is running in production labels Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meysholdt meysholdt meysholdt approved these changes

@mustard-mh mustard-mh mustard-mh approved these changes

+5 more reviewers

@felladrin felladrin felladrin approved these changes

@andreafalzetti andreafalzetti andreafalzetti approved these changes

@Pothulapati Pothulapati Pothulapati approved these changes

@sagor999 sagor999 sagor999 approved these changes

@jenting jenting jenting approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@aledbf aledbf

Labels
deployed: IDE IDE change is running in production deployed: workspace Workspace team change is running in production release-note-none size/M team: delivery Issue belongs to the self-hosted team team: devx team: IDE team: workspace Issue belongs to the Workspace team
Projects
No open projects
🌌 Workspace Team
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@aledbf @meysholdt @felladrin @andreafalzetti @Pothulapati @sagor999 @mustard-mh @jenting @roboquat