Skip to content

Move usageAttributionId #11522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2022
Merged

Move usageAttributionId #11522

merged 1 commit into from
Jul 21, 2022

Conversation

AlexTugarev
Copy link
Member

@AlexTugarev AlexTugarev commented Jul 21, 2022 •
edited
Loading

Description

This PR implements validations for setUsageAttribution in UserServer.
Also usageAttributionId is moved to be a field of User entity.

A follow-up to #10893

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview
  • /werft with-payment

@AlexTugarev AlexTugarev requested a review from a team July 21, 2022 09:09
@github-actions github-actions bot added team: webapp Issue belongs to the WebApp team and removed size/L labels Jul 21, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-at-usageattributionid.1 because the annotations in the pull request description changed
(with .werft/ from main)

AlexTugarev
AlexTugarev commented Jul 21, 2022
View reviewed changes
easyCZ
easyCZ reviewed Jul 21, 2022
View reviewed changes
AlexTugarev
AlexTugarev commented Jul 21, 2022
View reviewed changes
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-at-usageattributionid.2 because the annotations in the pull request description changed
(with .werft/ from main)

@AlexTugarev AlexTugarev force-pushed the at/usageAttributionId branch from c7484ab to c9f79d5 Compare July 21, 2022 09:34
easyCZ
easyCZ reviewed Jul 21, 2022
View reviewed changes
@AlexTugarev AlexTugarev force-pushed the at/usageAttributionId branch from c9f79d5 to dfaf840 Compare July 21, 2022 10:19
@AlexTugarev AlexTugarev force-pushed the at/usageAttributionId branch from dfaf840 to f763915 Compare July 21, 2022 11:09
@roboquat roboquat merged commit 472f0b7 into main Jul 21, 2022
@roboquat roboquat deleted the at/usageAttributionId branch July 21, 2022 11:55
@AlexTugarev
Copy link
Member Author

AlexTugarev commented Jul 21, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-at-usageattributionid.6
(with .werft/ from main)

@AlexTugarev AlexTugarev restored the at/usageAttributionId branch July 21, 2022 14:56
@AlexTugarev
Copy link
Member Author

AlexTugarev commented Jul 21, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-at-usageattributionid.8
(with .werft/ from main)

@AlexTugarev AlexTugarev mentioned this pull request Jul 21, 2022
Merged
2 tasks
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jul 26, 2022
@AlexTugarev AlexTugarev mentioned this pull request Aug 26, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyCZ easyCZ easyCZ approved these changes

Assignees

@easyCZ easyCZ

Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexTugarev @easyCZ @andrew-farries @roboquat