[db-sync] Escape column name in UPDATE statement #11286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-farries
force-pushed
the
af/fix-db-sync
branch
from
ae42cb1 to
2fc53a6
Compare
geropl
reviewed
Jul 11, 2022
| @@ -147,7 +147,7 @@ export class TableUpdate { | |||
| } | |||
|
|
|||
| protected getUpdateConditions(row: any): string { | |||
| return this.table.primaryKeys.map(pk => `${pk}=${escape(row[pk])}`).concat([`${this.table.timeColumn}<=${escape(row[this.table.timeColumn])}`]).join(" AND "); | |||
| return this.table.primaryKeys.map(pk => `${escapeWithBackticks(pk)}=${escape(row[pk])}`).concat([`${this.table.timeColumn}<=${escape(row[this.table.timeColumn])}`]).join(" AND "); | |||
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Escape column names in backquotes when
db-syncgeneratesUPDATEstatements.This ensures that
db-syncis able to generate these statements for tables having SQL keywords as column names.Related Issue(s)
Fixes #11265
How to test
Take the
db-syncimage built on this branch and hot-patch thedb-syncimage running in staging. See thatdb-syncruns without error in staging.Release Notes