[installer]: order the custom envvars #11001
Conversation
| @@ -521,13 +527,6 @@ func TestCustomizeEnvvar(t *testing.T) { | |||
|
|
|||
| result := common.CustomizeEnvvar(ctx, testCase.Component, testCase.ExistingEnnvars) | |||
|
|
|||
| sort.Slice(result, func(a, b int) bool { | |||
There was a problem hiding this comment.
Removing this ensures that the order generated by the function matches the expectation
github-actions
bot
added
the
team: delivery
|
@mrsimonemms: When it's true that the “map doesn't maintain any kind of stable ordering” as stated in the issue, then we would have the same issue with e.g. annotations (and maybe in several other places as well). I guess, in practice, we can assume that the order, in general, is the same in a map (even if that is not guaranteed), can't we? |
|
@corneliusludmann yes, you are correct. However, as these are already My guess is, knowing this, ArgoCD makes allowances for |
|
@mrsimonemms I think your guess is right. ArgoCD uses their GitOps Engine which I believe tries to be clever about these things. |
Description
Changes how the customize envvars orders it's output. It keeps the existing envvars in the order that's given and the customized envvars are ordered in terms of first one received. This is to avoid unnecessary deploys in a GitOps setup.
Overrides the "fix failing test" commit in #10836 by @Furisto - it achieves the same effect, but does so in the application code rather than the test
Related Issue(s)
Fixes #11000
How to test
The unit tests provides the test coverage. @mads-hartmann should check that the order is as expected
Release Notes
Documentation
Werft options: