Skip to content

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented May 24, 2022

Description

Initial setup to establish a database connection. This PR ensures that we can run tests against a DB both in a workspace, or in CI.

Related Issue(s)

Fixes #

How to test

cd components/usage && go test ./...
This will prompt you to run leeway components/usage:init-testdb to start the server
Then running above again, will result in tests passing.

This setup is already done in CI and mirrors how we run tests against gitpod-db component.

Release Notes

NONE

Documentation

NONE

@easyCZ easyCZ marked this pull request as ready for review May 27, 2022 07:44
@easyCZ easyCZ force-pushed the mp/db-conn branch 2 times, most recently from f574719 to dd421f6 Compare May 27, 2022 07:57
@easyCZ easyCZ requested a review from a team May 27, 2022 08:19
@easyCZ easyCZ changed the title [db-go] Establish database connection [usage] Establish database connection May 27, 2022
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label May 27, 2022
@geropl geropl self-assigned this May 30, 2022
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested and works ✔️

@roboquat roboquat merged commit 28f8c4f into main May 30, 2022
@roboquat roboquat deleted the mp/db-conn branch May 30, 2022 08:21
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants